All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Lars Schneider <larsxschneider@gmail.com>,
	Johannes Schindelin <johannes.schindelin@gmx.de>,
	git@vger.kernel.org
Subject: Re: 2.11.0-rc1 will not be tagged for a few days
Date: Fri, 11 Nov 2016 12:52:18 -0800	[thread overview]
Message-ID: <xmqq1syh3fjx.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <e0785e35-b43d-37ed-598d-b458daf3c355@kdbg.org> (Johannes Sixt's message of "Fri, 11 Nov 2016 21:44:32 +0100")

Johannes Sixt <j6t@kdbg.org> writes:

> Good to know that I am not alone. This one fails consistently for
> me. I dug into it a bit today, but it drives me mad. Process Monitor
> reports that the redirected-to file (git-stderr.log) gets marked as
> "Delete pending" by git.exe, but I have absolutely no clue where this
> is coming from. Git.exe has no business fuzzing with the file; it just
> has to write() something into it, if at all. When 'git checkout' ends,
> the file is closed, and removed due to the "Delete pending" mark. At
> the same time, git.exe finishes with non-zero exit code. For whatever
> reason.
>
>> FWIW: This patch (which would be the right thing to do anyways) seems to fix
>> the flakyness but I can't be sure ... it needs to run longer...
>>
>> diff --git a/t/t0021-conversion.sh b/t/t0021-conversion.sh
>> index 9ff5027..107766b 100755
>> --- a/t/t0021-conversion.sh
>> +++ b/t/t0021-conversion.sh
>> @@ -29,8 +29,7 @@ file_size () {
>>
>>  filter_git () {
>>  	rm -f rot13-filter.log &&
>> -	git "$@" 2>git-stderr.log &&
>> -	rm -f git-stderr.log
>> +	git "$@" 2>/dev/null
>
> If I remove the redirection altogether, the test passes for me
> consistently. The redirection isn't necessary anyway, it looks like a
> debugging left-over.

OK, then let's have

	filter_git () {
		rm -f rot13-filter.log &&
		git "$@"
                ...

and call that -rc1; to Windows folks, this is sweeping a mysterious
failure around git.exe under the rug, but for the purpose of the
overall project, it is far lower priority to figure out the reason
why a merely-redirected-into file is considered to be delete-pending
on WIndows than have something the end user can start testing and
complaining about new features and regressions.

Thanks.

  reply	other threads:[~2016-11-11 20:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07  2:32 2.11.0-rc1 will not be tagged for a few days Junio C Hamano
2016-11-08  0:40 ` Jeff King
2016-11-08  6:25   ` Johannes Sixt
2016-11-08 21:48     ` Jeff King
2016-11-09  6:29       ` Junio C Hamano
2016-11-09 16:51         ` Jeff King
2016-11-09 23:35           ` Junio C Hamano
2016-11-09 23:40   ` Junio C Hamano
2016-11-10 21:43 ` Junio C Hamano
2016-11-11  0:26   ` Junio C Hamano
2016-11-11 16:13   ` Johannes Schindelin
2016-11-11 17:02     ` Johannes Schindelin
2016-11-11 17:05     ` Lars Schneider
2016-11-11 17:31       ` Lars Schneider
2016-11-11 17:38         ` Lars Schneider
2016-11-11 20:44           ` Johannes Sixt
2016-11-11 20:52             ` Junio C Hamano [this message]
2016-11-11 21:07               ` Junio C Hamano
2016-11-11 21:22                 ` Johannes Sixt
2016-11-12 13:33                   ` Lars Schneider
2016-11-11 17:41       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1syh3fjx.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=larsxschneider@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.