From: Junio C Hamano <gitster@pobox.com>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: git@vger.kernel.org, sunshine@sunshineco.com
Subject: Re: [PATCH v1] git-p4: fix AsciiDoc formatting
Date: Sun, 13 Mar 2016 20:51:00 -0700 [thread overview]
Message-ID: <xmqq1t7dafa3.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <F0F4FA8A-EB42-4990-A90E-6C9245E0A9DE@gmail.com> (Lars Schneider's message of "Sun, 13 Mar 2016 18:46:36 +0100")
Lars Schneider <larsxschneider@gmail.com> writes:
>> diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt
>> index 738cfde..140fc12 100644
>> --- a/Documentation/git-p4.txt
>> +++ b/Documentation/git-p4.txt
>> @@ -528,7 +528,7 @@ git-p4.largeFileSystem::
>> git config git-p4.largeFileSystem GitLFS
>> -------------
>> +
>> - [1] https://git-lfs.github.com/
>> +[1] https://git-lfs.github.com/
>>
>> git-p4.largeFileExtensions::
>> All files matching a file extension in the list will be processed
>> --
>> 2.5.1
>>
>
> Is there any chance to get this in? The formatting error is quite obvious here:
> https://git-scm.com/docs/git-p4
>
> (while looking at this website I also noticed wrong double quotes around cp1252
> which I will fix with a subsequent patch)
I ignored this when I saw it first, primarily because I assumed that
anything related to git-p4 would get a review by somebody better
versed with git-p4 before I get to it; I forgot about the patch
after it was buried in the other messages without anything
happening.
Will take a look.
Thanks.
next prev parent reply other threads:[~2016-03-14 3:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 11:05 [PATCH v1] git-p4: fix AsciiDoc formatting larsxschneider
2016-03-13 17:46 ` Lars Schneider
2016-03-14 3:51 ` Junio C Hamano [this message]
2016-03-15 8:38 ` Luke Diamand
2016-03-15 9:09 ` Lars Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1t7dafa3.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.