All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Andrew Ardill <andrew.ardill@gmail.com>,
	"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Gated Merge?
Date: Fri, 12 Feb 2016 11:06:04 -0800	[thread overview]
Message-ID: <xmqq1t8hvjdv.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160212190017.GA20801@sigill.intra.peff.net> (Jeff King's message of "Fri, 12 Feb 2016 14:00:17 -0500")

Jeff King <peff@peff.net> writes:

> But I don't think this needs to have anything to do with merges in
> particular, or rules like "when merging a branch that does not have me
> in it". It is about saying "from here on out, the tree state should
> match this property, and we can test it by running this script". And
> then running "make code-lint-tests" becomes part of the acceptance
> testing for a proposed topic merge, just like "make test" is already
> (and likewise, people forking _new_ branches from master after the topic
> is merged would make sure they do not fail the code-lint tests before
> even submitting the topic).

That certainly is true, but this strays more and more from my
original motive of implementing an automated evil-merge scheme that
is better than what I currently have.

We try to do our tree-wide refactoring in such a way that it would
break the compilation (by changing function signature) when we can.
Catching with "make test" would certainly generalize it, but the
endgame result I was shooting for was to come up with a solution for
each topic in-flight just once and keep replaying it until it is
merged.

  reply	other threads:[~2016-02-12 19:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-11 22:06 Gated Merge? Junio C Hamano
2016-02-11 22:42 ` Andrew Ardill
2016-02-11 23:53   ` Stefan Beller
2016-02-12 17:44   ` Junio C Hamano
2016-02-12 19:00     ` Jeff King
2016-02-12 19:06       ` Junio C Hamano [this message]
2016-02-12 19:26         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1t8hvjdv.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=andrew.ardill@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.