From: Junio C Hamano <gitster@pobox.com>
To: Philip Oakley <philipoakley@iee.org>
Cc: Git List <git@vger.kernel.org>, Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v2b 00/16, 2 updates] Make the msvc-build scripts work again
Date: Mon, 20 Jul 2015 16:07:18 -0700 [thread overview]
Message-ID: <xmqq1tg2xwbd.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1437432846-5796-1-git-send-email-philipoakley@iee.org> (Philip Oakley's message of "Mon, 20 Jul 2015 23:54:04 +0100")
Philip Oakley <philipoakley@iee.org> writes:
> This updates two patches in the series based on Eric Sunshine's comments.
>
> Patch 8b updates the commit message to make clear what was going wrong.
>
> Patch 10b improves the perl code.
Is v2b like saying v3 or something else? Does 8b replaces 8 or
updates it (i.e. comes between 8 and 9)?
> Junio: would a full re-roll be appropriate at a suitable point?
Probably, but I'd like to see people try it out and give positive
feedback first. This part of the tree I can give no input or pre-
pushout testing at all.
Who are the people involved in this part of the system in the past?
Does "shortlog -n --no-merges contrib/buildsystems compat/vcbuild"
tell us anything?
> Philip Oakley (2):
>
> engine.pl: ignore invalidcontinue.obj which is known to MSVC
> engine.pl: delete the captured stderr file if empty
next prev parent reply other threads:[~2015-07-20 23:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 22:54 [PATCH v2b 00/16, 2 updates] Make the msvc-build scripts work again Philip Oakley
2015-07-20 22:54 ` [PATCH v2 8b/16] engine.pl: ignore invalidcontinue.obj which is known to MSVC Philip Oakley
2015-07-20 22:54 ` [PATCH v2 10b/16] engine.pl: delete the captured stderr file if empty Philip Oakley
2015-07-20 23:07 ` Junio C Hamano [this message]
2015-07-21 16:46 ` [PATCH v2b 00/16, 2 updates] Make the msvc-build scripts work again Philip Oakley
2015-07-21 19:25 ` Junio C Hamano
2015-07-21 20:04 ` Junio C Hamano
2015-07-21 20:39 ` Philip Oakley
2015-07-22 22:57 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1tg2xwbd.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=philipoakley@iee.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.