From: Junio C Hamano <gitster@pobox.com>
To: Mike Blume <blume.mike@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] allow TTY tests to run under recent Mac OS
Date: Thu, 13 Nov 2014 14:21:42 -0800 [thread overview]
Message-ID: <xmqq1tp6zqq1.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1415916087-18953-1-git-send-email-blume.mike@gmail.com> (Mike Blume's message of "Thu, 13 Nov 2014 14:01:27 -0800")
Mike Blume <blume.mike@gmail.com> writes:
> listed bug doesn't reproduce on Mac OS Yosemite. For now, just enable
> TTY on Yosemite and higher
>
> Signed-off-by: Mike Blume <blume.mike@gmail.com>
> ---
> t/lib-terminal.sh | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/t/lib-terminal.sh b/t/lib-terminal.sh
> index 5184549..1311ce0 100644
> --- a/t/lib-terminal.sh
> +++ b/t/lib-terminal.sh
> @@ -29,7 +29,10 @@ test_lazy_prereq TTY '
> # After 2000 iterations or so it hangs.
> # https://rt.cpan.org/Ticket/Display.html?id=65692
> #
> - test "$(uname -s)" != Darwin &&
> + # Under Mac OS X 10.10.1 and Perl 5.18.2, this problem
> + # appears to be gone.
> + #
> + [[ test "$(uname -s)" != Darwin || test "$(uname -r | cut -d. -f1") -ge 14 ]] &&
This is designed to be a plain vanilla POSIX shell script. Please
avoid these double brackets.
>
> perl "$TEST_DIRECTORY"/test-terminal.perl \
> sh -c "test -t 1 && test -t 2"
next prev parent reply other threads:[~2014-11-13 22:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 22:01 [PATCH] allow TTY tests to run under recent Mac OS Mike Blume
2014-11-13 22:21 ` Junio C Hamano [this message]
2014-11-13 22:40 ` Michael Blume
2014-11-14 5:24 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1tp6zqq1.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=blume.mike@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.