From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Siddharth Agarwal <sid0@fb.com>, Vicent Marti <tanoku@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] repack: add `repack.honorpackkeep` config var
Date: Mon, 24 Feb 2014 11:10:49 -0800 [thread overview]
Message-ID: <xmqq1tys9vie.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140224082459.GA32594@sigill.intra.peff.net> (Jeff King's message of "Mon, 24 Feb 2014 03:24:59 -0500")
Jeff King <peff@peff.net> writes:
> Sorry, this one slipped through the cracks. Here's a re-roll addressing
> your comments.
> ...
>> - In the context of "pack-objects", the name "--honor-pack-keep"
>> makes sense; it is understood that pack-objects will _not_ remove
>> kept packfile, so "honoring" can only mean "do not attempt to
>> pick objects out of kept packs to add to the pack being
>> generated." and there is no room for --no-honor-pack-keep to be
>> mistaken as "you canremove the ones marked to be kept after
>> saving the still-used objects in it away."
>>
>> But does the same name make sense in the context of "repack"?
>
> I think the distinction you are making is to capture the second second
> from the docs:
>
> If set to false, include objects in `.keep` files when repacking via
> `git repack`. Note that we still do not delete `.keep` packs after
> `pack-objects` finishes.
>
> The best name I could come up with is "--pack-keep-objects", since that
> is literally what it is doing. I'm not wild about the name because it is
> easy to read "keep" as a verb (and "pack" as a noun). I think it's OK,
> but suggestions are welcome.
pack-kept-objects then?
next prev parent reply other threads:[~2014-02-24 19:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 2:38 WIth git-next, writing bitmaps fails when keep files are present Siddharth Agarwal
2014-01-23 20:36 ` Siddharth Agarwal
2014-01-23 22:52 ` [PATCH] pack-objects: turn off bitmaps when skipping objects Jeff King
2014-01-23 23:45 ` Siddharth Agarwal
2014-01-23 23:53 ` Siddharth Agarwal
2014-01-24 2:28 ` Jeff King
2014-01-24 2:44 ` Siddharth Agarwal
2014-01-28 6:09 ` [PATCH] repack: add `repack.honorpackkeep` config var Jeff King
2014-01-28 9:21 ` Junio C Hamano
2014-02-24 8:24 ` Jeff King
2014-02-24 19:10 ` Junio C Hamano [this message]
2014-02-26 10:13 ` Jeff King
2014-02-26 20:30 ` Junio C Hamano
2014-02-27 11:27 ` Jeff King
2014-02-27 18:04 ` Junio C Hamano
2014-02-28 8:55 ` Jeff King
2014-02-28 17:09 ` Nasser Grainawi
2014-03-01 6:05 ` Jeff King
2014-03-03 19:12 ` Shawn Pearce
2014-02-28 18:45 ` Junio C Hamano
2014-03-01 5:43 ` Jeff King
2014-03-03 18:13 ` Junio C Hamano
2014-03-03 18:15 ` Jeff King
2014-03-03 19:51 ` Junio C Hamano
2014-03-03 20:04 ` Jeff King
2014-01-23 23:56 ` [PATCH] pack-objects: turn off bitmaps when skipping objects Vicent Martí
2014-01-24 2:26 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1tys9vie.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sid0@fb.com \
--cc=tanoku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.