From: Junio C Hamano <gitster@pobox.com>
To: "Øystein Walle" <oystwa@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] for-each-ref: add option to omit newlines
Date: Fri, 14 Feb 2014 15:24:51 -0800 [thread overview]
Message-ID: <xmqq1tz5gtvg.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <loom.20140215T000328-538@post.gmane.org> ("Øystein Walle"'s message of "Fri, 14 Feb 2014 23:03:21 +0000 (UTC)")
Øystein Walle <oystwa@gmail.com> writes:
> Maybe it's all subjective... I'm okay with just leaving things as they
> are.
Lack of "-z" in for-each-ref can be called an inconsistency that
already exists you may want to fix in any case.
As an extension to that, I would not be fundamentally against a new
option, e.g. "--terminiator=7", that causes us to use putchar(7)
instead of putchar('\n') or putchar('\0') to terminate each records.
At that point, "-z" becomes a synonym for "--terminator=0".
And "--terminator=''" might even be a natural extension to that
option to cause us not to call any putchar() there.
If we were to do that, we should do them for all commands that let
you use "-z", not just for-each-ref, for consistency reasons, I
would think.
prev parent reply other threads:[~2014-02-14 23:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 18:00 [PATCH] for-each-ref: add option to omit newlines Øystein Walle
2014-02-13 18:15 ` Øystein Walle
2014-02-13 20:10 ` Junio C Hamano
2014-02-14 8:11 ` Øystein Walle
2014-02-14 16:28 ` Junio C Hamano
2014-02-14 23:03 ` Øystein Walle
2014-02-14 23:24 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1tz5gtvg.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=oystwa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.