From: Junio C Hamano <gitster@pobox.com>
To: Tony Finch <dot@dotat.at>
Cc: git@vger.kernel.org, "Jakub Narębski" <jnareb@gmail.com>,
"Jonathan Nieder" <jrnieder@gmail.com>
Subject: Re: [PATCH v4 2/4] gitweb: vertically centre contents of page footer
Date: Tue, 20 Aug 2013 12:53:59 -0700 [thread overview]
Message-ID: <xmqq1u5ow33c.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <5c4afd189553d0f1e83b0c2b9758643deba5a671.1377019362.git.dot@dotat.at> (Tony Finch's message of "Tue, 20 Aug 2013 17:59:03 +0100")
Tony Finch <dot@dotat.at> writes:
> Signed-off-by: Tony Finch <dot@dotat.at>
> ---
> gitweb/static/gitweb.css | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css
> index a869be1..3b4d833 100644
> --- a/gitweb/static/gitweb.css
> +++ b/gitweb/static/gitweb.css
> @@ -68,12 +68,13 @@ div.page_path {
> }
>
> div.page_footer {
> - height: 17px;
> + height: 22px;
> padding: 4px 8px;
> background-color: #d9d8d1;
> }
>
> div.page_footer_text {
> + line-height: 22px;
> float: left;
> color: #555555;
> font-style: italic;
Hmmm, is it a good idea to do "px" here, or are they ways to do
relative to x-height or something to make sure the text fits?
next prev parent reply other threads:[~2013-08-20 19:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 16:43 [PATCH] gitweb: Ensure OPML text fits inside its box Tony Finch
2013-07-09 17:08 ` [PATCH] gitweb: vertically centre contents of page footer Tony Finch
2013-07-14 23:49 ` [PATCH] gitweb: Ensure OPML text fits inside its box Jonathan Nieder
2013-07-02 16:24 ` [PATCH 3/4] gitweb: omit the repository owner when it is unset Tony Finch
2013-07-09 16:43 ` [PATCH 1/4] gitweb: Ensure OPML text fits inside its box Tony Finch
2013-07-09 17:08 ` [PATCH 2/4] gitweb: vertically centre contents of page footer Tony Finch
2013-07-09 17:15 ` [PATCH 4/4] gitweb: make search help link less ugly Tony Finch
2013-07-15 9:15 ` [PATCH] gitweb: Ensure OPML text fits inside its box Tony Finch
[not found] ` <E1Uyeth-0003TF-Kx@hermes-2.csi.cam.ac.uk>
2013-08-03 21:37 ` [PATCH 4/4] gitweb: make search help link less ugly Jakub Narębski
2013-08-05 11:19 ` Tony Finch
[not found] ` <E1Uyete-0003Sv-OI@hermes-2.csi.cam.ac.uk>
2013-08-03 21:40 ` [PATCH 3/4] gitweb: omit the repository owner when it is unset Jakub Narębski
2013-08-05 11:36 ` Tony Finch
2013-08-20 17:22 ` [PATCH v4 0/4] Four small gitweb tweaks Tony Finch
2013-08-20 16:59 ` [PATCH v4 1/4] gitweb: Ensure OPML text fits inside its box Tony Finch
2013-08-20 19:52 ` Junio C Hamano
2013-08-20 16:59 ` [PATCH v4 2/4] gitweb: vertically centre contents of page footer Tony Finch
2013-08-20 19:53 ` Junio C Hamano [this message]
2013-08-21 9:06 ` Tony Finch
2013-08-20 16:59 ` [PATCH v4 3/4] gitweb: omit the repository owner when it is unset Tony Finch
2013-08-20 16:59 ` [PATCH v4 4/4] gitweb: make search help link less ugly Tony Finch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1u5ow33c.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=dot@dotat.at \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.