From: Junio C Hamano <gitster@pobox.com>
To: Ben Knoble <ben.knoble@gmail.com>
Cc: Siddharth Shrimali <r.siddharth.shrimali@gmail.com>,
git@vger.kernel.org, coygeek@gmail.com
Subject: Re: [PATCH v2] repack: do not rebuild packs on --dry-run
Date: Sat, 10 Oct 2026 22:57:27 -0700 [thread overview]
Message-ID: <xmqq33ucg4oo.fsf@gitster.g> (raw)
In-Reply-To: <BBCEC2F7-CA8A-4460-8A4F-D8305D3E9134@gmail.com> (Ben Knoble's message of "Sat, 10 Oct 2026 17:06:18 -0400")
Ben Knoble <ben.knoble@gmail.com> writes:
>> ...
>> Fix it by returning right after the candidates are listed, and add a
>> test that checks the pack directory is unchanged with and without -d.
>>
>> Reported-by: Coy Geek <coygeek@gmail.com>
>> Helped-by: D. Ben Knoble <ben.knoble@gmail.com>
>> Signed-off-by: Siddharth Shrimali <r.siddharth.shrimali@gmail.com>
>> ---
>> Bug report:
>> https://lore.kernel.org/git/CACgTecOm+=vbf50tZNXhcYvRi1ZTsQwbjVoJAbQqs2CmXdJCxg@mail.gmail.com/
>>
>> Changes since v1:
>> - reworded the comment
>> - documented the bug in the log message
>
> Thanks, I’m happy with this version. You may add my Reviewed-by, if you like
Thanks for writing and reviewing. Let me mark the topic for 'next'.
next prev parent reply other threads:[~2026-10-11 5:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 6:25 [PATCH] repack: do not rebuild packs on --dry-run Siddharth Shrimali
2026-10-08 12:56 ` D. Ben Knoble
2026-10-10 19:53 ` Siddharth Shrimali
2026-10-08 14:23 ` Junio C Hamano
2026-10-10 20:05 ` Siddharth Shrimali
2026-10-10 21:00 ` [PATCH v2] " Siddharth Shrimali
2026-10-10 21:06 ` Ben Knoble
2026-10-11 5:57 ` Junio C Hamano [this message]
2026-10-13 11:30 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq33ucg4oo.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble@gmail.com \
--cc=coygeek@gmail.com \
--cc=git@vger.kernel.org \
--cc=r.siddharth.shrimali@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.