From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>,
"D. Ben Knoble" <ben.knoble@gmail.com>,
Tian Yuchen <cat@malon.dev>
Cc: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Subject: Re: [PATCH v3 0/3] builtin/history: introduce "fixup" subcommand
Date: Tue, 12 May 2026 14:47:41 +0900 [thread overview]
Message-ID: <xmqq33zxp4aq.fsf@gitster.g> (raw)
In-Reply-To: <20260427-b4-pks-history-fixup-v3-0-cb908f06264b@pks.im> (Patrick Steinhardt's message of "Mon, 27 Apr 2026 07:53:50 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> this short patch series introduces a new "fixup" subcommand. This
> command is the first one that I felt is missing in my day to day work,
> as I end up doing fixup commits quite often.
>
> The flow is rather simple: the user stages some changes, and then they
> execute `git history fixup <commit>` to amend those changes to the given
> commit. As with the other subcommands, dependent branches will then be
> rebased automatically.
>
> This is the first command that may result in merge conflicts. For now we
> simply abort in such cases, but there are plans to introduce first-class
> conflicts into Git. So once we have them, we'll also be able to handle
> such cases more gracefully. I still think that the command is useful
> even without that conflict handling.
>
> Changes in v3:
> - Some more polishing of the command's description.
> - Link to v2: https://patch.msgid.link/20260423-b4-pks-history-fixup-v2-0-d7571c6d36eb@pks.im
>
> Changes in v2:
> - Introduce "--empty=(keep|drop|abort)" to specify what happens with
> empty commits.
> - Adapt documentation a bit to hopefully clarify how changes are
> backported.
> - Link to v1: https://patch.msgid.link/20260422-b4-pks-history-fixup-v1-0-48d4484243de@pks.im
The iterations v2 and v3 saw no comments, unfortunately. I just
gave three patches in v3 a cursory look and nothing stood out as
curious or fishy. Shall we mark the topic for 'next' now?
next prev parent reply other threads:[~2026-05-12 5:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 10:28 [PATCH 0/2] builtin/history: introduce "fixup" subcommand Patrick Steinhardt
2026-04-22 10:28 ` [PATCH 1/2] builtin/history: generalize function to commit trees Patrick Steinhardt
2026-04-22 10:28 ` [PATCH 2/2] builtin/history: introduce "fixup" subcommand Patrick Steinhardt
2026-04-22 19:06 ` D. Ben Knoble
2026-04-23 6:55 ` Patrick Steinhardt
2026-04-23 21:18 ` D. Ben Knoble
2026-04-24 6:53 ` Patrick Steinhardt
2026-04-24 14:43 ` D. Ben Knoble
2026-04-22 18:18 ` [PATCH 0/2] " Tian Yuchen
2026-04-23 6:55 ` Patrick Steinhardt
2026-04-23 14:21 ` [PATCH v2 0/3] " Patrick Steinhardt
2026-04-23 14:21 ` [PATCH v2 1/3] replay: allow callers to control what happens with empty commits Patrick Steinhardt
2026-04-23 14:21 ` [PATCH v2 2/3] builtin/history: generalize function to commit trees Patrick Steinhardt
2026-04-23 14:21 ` [PATCH v2 3/3] builtin/history: introduce "fixup" subcommand Patrick Steinhardt
2026-04-27 5:53 ` [PATCH v3 0/3] " Patrick Steinhardt
2026-04-27 5:53 ` [PATCH v3 1/3] replay: allow callers to control what happens with empty commits Patrick Steinhardt
2026-05-12 4:51 ` Junio C Hamano
2026-04-27 5:53 ` [PATCH v3 2/3] builtin/history: generalize function to commit trees Patrick Steinhardt
2026-04-27 5:53 ` [PATCH v3 3/3] builtin/history: introduce "fixup" subcommand Patrick Steinhardt
2026-05-12 5:47 ` Junio C Hamano [this message]
2026-05-12 6:41 ` [PATCH v3 0/3] " Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq33zxp4aq.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble@gmail.com \
--cc=cat@malon.dev \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.