From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Karthik Nayak <karthik.188@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 05/13] object-file: introduce `struct odb_loose_source`
Date: Fri, 31 Oct 2025 09:10:29 -0700 [thread overview]
Message-ID: <xmqq346z2gsq.fsf@gitster.g> (raw)
In-Reply-To: <aQNMwve9sUP-QDN6@pks.im> (Patrick Steinhardt's message of "Thu, 30 Oct 2025 12:32:18 +0100")
Patrick Steinhardt <ps@pks.im> writes:
>> I wonder if the naming should instead be `struct obd_source_loose` that
>> way other backends (if added) would be something like:
>>
>> struct obd_source_loose
>> struct obd_source_postgres
>> struct obd_source_mongo
>>
>> This is easier to read and also for autocompletion it leads nicely into
>> the 'obd_source_...' namespace.
>
> Hm, I see your point. I think that "loose source" flows a bit more
> natural, but I agree that the above is more accessible in code.
>
> Before I change this: does anybody else have an opinion here?
I have a slight preference for what Karthik suggested. To me,
"There are three variants of odb-source, which are odb-source-A,
odb-source-B and odb-source-C" flows more naturally than
"odb-A-source, odb-B-source, ..."
next prev parent reply other threads:[~2025-10-31 16:10 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 9:55 [PATCH 00/13] Carve out loose object source Patrick Steinhardt
2025-10-24 9:56 ` [PATCH 01/13] odb: fix subtle logic to check whether an alternate is usable Patrick Steinhardt
2025-10-24 16:21 ` Junio C Hamano
2025-10-30 10:34 ` Karthik Nayak
2025-10-24 9:56 ` [PATCH 02/13] odb: introduce `odb_source_new()` Patrick Steinhardt
2025-10-24 16:37 ` Junio C Hamano
2025-10-27 11:21 ` Patrick Steinhardt
2025-10-24 9:56 ` [PATCH 03/13] odb: adjust naming to free object sources Patrick Steinhardt
2025-10-30 10:41 ` Karthik Nayak
2025-10-24 9:56 ` [PATCH 04/13] object-file: move `fetch_if_missing` Patrick Steinhardt
2025-10-24 9:56 ` [PATCH 05/13] object-file: introduce `struct odb_loose_source` Patrick Steinhardt
2025-10-30 10:47 ` Karthik Nayak
2025-10-30 11:32 ` Patrick Steinhardt
2025-10-31 6:11 ` Patrick Steinhardt
2025-10-31 16:16 ` Junio C Hamano
2025-11-03 7:19 ` Patrick Steinhardt
2025-10-31 16:10 ` Junio C Hamano [this message]
2025-10-24 9:56 ` [PATCH 06/13] object-file: move loose object cache into loose source Patrick Steinhardt
2025-10-24 21:44 ` Junio C Hamano
2025-10-27 11:21 ` Patrick Steinhardt
2025-10-24 9:56 ` [PATCH 07/13] object-file: hide internals when we need to reprepare loose sources Patrick Steinhardt
2025-10-24 9:56 ` [PATCH 08/13] object-file: move loose object map into loose source Patrick Steinhardt
2025-10-24 9:56 ` [PATCH 09/13] object-file: read objects via the loose object source Patrick Steinhardt
2025-10-30 12:19 ` Karthik Nayak
2025-10-24 9:56 ` [PATCH 10/13] object-file: rename `has_loose_object()` Patrick Steinhardt
2025-10-24 9:56 ` [PATCH 11/13] object-file: refactor freshening of objects Patrick Steinhardt
2025-10-24 9:56 ` [PATCH 12/13] object-file: rename `write_object_file()` Patrick Steinhardt
2025-10-24 9:56 ` [PATCH 13/13] object-file: refactor writing objects via a stream Patrick Steinhardt
2025-10-30 12:24 ` [PATCH 00/13] Carve out loose object source Karthik Nayak
2025-10-31 6:12 ` [PATCH v2 " Patrick Steinhardt
2025-10-31 6:12 ` [PATCH v2 01/13] odb: fix subtle logic to check whether an alternate is usable Patrick Steinhardt
2025-10-31 6:12 ` [PATCH v2 02/13] odb: introduce `odb_source_new()` Patrick Steinhardt
2025-10-31 6:12 ` [PATCH v2 03/13] odb: adjust naming to free object sources Patrick Steinhardt
2025-10-31 6:12 ` [PATCH v2 04/13] object-file: move `fetch_if_missing` Patrick Steinhardt
2025-10-31 6:12 ` [PATCH v2 05/13] object-file: introduce `struct odb_loose_source` Patrick Steinhardt
2025-10-31 6:12 ` [PATCH v2 06/13] object-file: move loose object cache into loose source Patrick Steinhardt
2025-10-31 6:12 ` [PATCH v2 07/13] object-file: hide internals when we need to reprepare loose sources Patrick Steinhardt
2025-10-31 6:12 ` [PATCH v2 08/13] object-file: move loose object map into loose source Patrick Steinhardt
2025-10-31 6:12 ` [PATCH v2 09/13] object-file: read objects via the loose object source Patrick Steinhardt
2025-10-31 6:12 ` [PATCH v2 10/13] object-file: rename `has_loose_object()` Patrick Steinhardt
2025-10-31 6:12 ` [PATCH v2 11/13] object-file: refactor freshening of objects Patrick Steinhardt
2025-10-31 6:12 ` [PATCH v2 12/13] object-file: rename `write_object_file()` Patrick Steinhardt
2025-10-31 6:12 ` [PATCH v2 13/13] object-file: refactor writing objects via a stream Patrick Steinhardt
2025-11-03 7:41 ` [PATCH v3 00/13] Carve out loose object source Patrick Steinhardt
2025-11-03 7:41 ` [PATCH v3 01/13] odb: fix subtle logic to check whether an alternate is usable Patrick Steinhardt
2025-11-03 7:41 ` [PATCH v3 02/13] odb: introduce `odb_source_new()` Patrick Steinhardt
2025-11-03 7:41 ` [PATCH v3 03/13] odb: adjust naming to free object sources Patrick Steinhardt
2025-11-03 7:41 ` [PATCH v3 04/13] object-file: move `fetch_if_missing` Patrick Steinhardt
2025-11-03 7:42 ` [PATCH v3 05/13] object-file: introduce `struct odb_source_loose` Patrick Steinhardt
2025-11-03 7:42 ` [PATCH v3 06/13] object-file: move loose object cache into loose source Patrick Steinhardt
2025-11-03 7:42 ` [PATCH v3 07/13] object-file: hide internals when we need to reprepare loose sources Patrick Steinhardt
2025-11-03 7:42 ` [PATCH v3 08/13] object-file: move loose object map into loose source Patrick Steinhardt
2025-11-03 7:42 ` [PATCH v3 09/13] object-file: read objects via the loose object source Patrick Steinhardt
2025-11-03 7:42 ` [PATCH v3 10/13] object-file: rename `has_loose_object()` Patrick Steinhardt
2025-11-03 7:42 ` [PATCH v3 11/13] object-file: refactor freshening of objects Patrick Steinhardt
2025-11-03 7:42 ` [PATCH v3 12/13] object-file: rename `write_object_file()` Patrick Steinhardt
2025-11-03 7:42 ` [PATCH v3 13/13] object-file: refactor writing objects via a stream Patrick Steinhardt
2025-11-03 13:39 ` [PATCH v3 00/13] Carve out loose object source Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq346z2gsq.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.