All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Renato Botelho <garga@FreeBSD.org>
Cc: Ramsay Jones <ramsay@ramsayjones.plus.com>,
	 Patrick Steinhardt <ps@pks.im>,
	 GIT Mailing-list <git@vger.kernel.org>
Subject: Re: Bug: build is broken on FreeBSD if libsysinfo is installed
Date: Wed, 02 Jul 2025 10:08:37 -0700	[thread overview]
Message-ID: <xmqq34beed0q.fsf@gitster.g> (raw)
In-Reply-To: <818958f6-7387-48f8-a0a8-c050af212069@FreeBSD.org> (Renato Botelho's message of "Wed, 2 Jul 2025 08:28:10 -0300")

Renato Botelho <garga@FreeBSD.org> writes:

>> I very quickly knocked up a patch to do the last option above (I
>> moved
>> the setting of HAVE_SYSINFO down the file rather that HAVE_BSD_SYSCTL
>> up. I guess it doesn't matter, but I gave it *no* thought!).
>> The patch is below. (I didn't write a commit message ;) ).
>> Does this work for you?
>
> Your patch works just fine for FreeBSD.  I tried it with libsysinfo
> installed and it just ignored it, as expected.
>
> I didn't test meson build since FreeBSD ports is based on autotools yet.
>
> BTW, should I start moving the port to meson?  Is it the default build
> method now?  Is there a plan to remove autotools?
>
> Thank you!

So we have a bit of loose end that needs a finishing touch, but
otherwise we are good to go?

Thanks, both.  


  reply	other threads:[~2025-07-02 17:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-23 14:09 Bug: build is broken on FreeBSD if libsysinfo is installed Renato Botelho
2025-07-01 16:05 ` Renato Botelho
2025-07-01 20:03   ` Eric Sunshine
2025-07-01 20:03   ` Ramsay Jones
2025-07-02 11:28     ` Renato Botelho
2025-07-02 17:08       ` Junio C Hamano [this message]
2025-07-02 19:48         ` Renato Botelho
2025-07-02 22:37           ` Ramsay Jones
2025-07-02 23:08             ` Junio C Hamano
2025-07-02 22:33       ` Ramsay Jones
2025-07-03  8:40         ` Patrick Steinhardt
2025-07-03 12:35           ` Renato Botelho
2025-07-03 13:02             ` Patrick Steinhardt
2025-07-02 18:32     ` Eli Schwartz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq34beed0q.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=garga@FreeBSD.org \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.