All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jan 2025, #05; Fri, 17)
Date: Sat, 18 Jan 2025 09:17:32 -0800	[thread overview]
Message-ID: <xmqq34hg3utv.fsf@gitster.g> (raw)
In-Reply-To: <20250118131507.GA387197@coredump.intra.peff.net> (Jeff King's message of "Sat, 18 Jan 2025 08:15:07 -0500")

Jeff King <peff@peff.net> writes:

> On Fri, Jan 17, 2025 at 04:42:01PM -0800, Junio C Hamano wrote:
>
>> * jk/pack-header-parse-alignment-fix (2025-01-17) 3 commits
>> ...
>>  Will merge to 'next'.
>>  source: <20250117125207.GB2356599@coredump.intra.peff.net>
>
> I was planning to re-roll this with your sparse fix included, and adding
> another patch to do get_be32() on the reading side. So maybe hold off
> for a moment.

Thanks.

> (I'd also be interested in any comments on the "maybe we should just
> align these buffers" approach; I'm undecided on it).

Unless we have the buffer _inside_ the helper function that may
perform the possibly-unaligned access, I am not sure how it helps.

I guess that we can align buffers used by two existing callers,
document that the helper function takes an aligned buffer and that
it is a fault of the caller if somebody passes an unaligned buffer,
but I am not sure if that is where we want to go.

  reply	other threads:[~2025-01-18 17:17 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-18  0:42 What's cooking in git.git (Jan 2025, #05; Fri, 17) Junio C Hamano
2025-01-18 13:15 ` Jeff King
2025-01-18 17:17   ` Junio C Hamano [this message]
2025-01-19 12:51     ` Jeff King
2025-01-19 12:55       ` Jeff King
2025-01-21 19:17         ` Junio C Hamano
2025-01-20  6:53 ` David Aguilar
2025-01-20  7:54   ` [PATCH] help: make help.autocorrect = 1 the same as "prompt" David Aguilar
2025-01-21 19:23   ` What's cooking in git.git (Jan 2025, #05; Fri, 17) Junio C Hamano
2025-01-21 20:19 ` Derrick Stolee
2025-01-21 20:30   ` Junio C Hamano
2025-01-22 18:30     ` Taylor Blau
2025-01-22 22:13       ` Junio C Hamano
2025-01-23 23:05         ` Taylor Blau
2025-01-23 23:46           ` Junio C Hamano
2025-01-22 16:44 ` Karthik Nayak
2025-01-22 17:28   ` Karthik Nayak
2025-01-22 17:38     ` Junio C Hamano
2025-01-23 17:22     ` Junio C Hamano
2025-01-23 17:45       ` Patrick Steinhardt
2025-01-23 18:25         ` Junio C Hamano
2025-01-24 11:05         ` Karthik Nayak
2025-01-24 17:06           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq34hg3utv.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.