All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
Cc: "Josh Soref" <gitgitgadget@gmail.com>,
	 git@vger.kernel.org,  "Andrew Kreimer" <algonell@gmail.com>,
	 "Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH 00/20] Fix typos
Date: Thu, 19 Sep 2024 13:42:19 -0700	[thread overview]
Message-ID: <xmqq34lv74us.fsf@gitster.g> (raw)
In-Reply-To: <ab9213d5-fb1b-482e-854b-4f5d4e82821a@app.fastmail.com> (Kristoffer Haugsbakk's message of "Thu, 19 Sep 2024 22:33:18 +0200")

"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:

> All of these look correct.
>
> Maybe all of the commits could be combined into one commit with the
> message “treewide: fix typos”.  But that wasn’t asked for last time.[1]
> So I dunno.

It depends.  When done carefully to make sure that nothing textually
conflicts with any topics in flight, a single "treewide" patch is
slightly nicer.  If nothing conflicts with nothing else, either
format is fine.  If something have nasty conflicts (e.g., a refactor
moved the comment with typos far from the original location or even
to a different file), individual patch form is easier to discard the
ones that need to wait.

I do not know which case this 20-patch collection falls into.

Thanks.

  reply	other threads:[~2024-09-19 20:42 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-19 18:34 [PATCH 00/20] Fix typos Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 01/20] config.mak.dev: fix a typo Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 02/20] diffcore-rename: fix typos Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 03/20] fsmonitor-settings: fix a typo Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 04/20] git-instaweb: " Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 05/20] git-p4: fix typos Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 06/20] gpg-interface: fix a typo Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 07/20] http: " Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 08/20] merge-ll: " Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 09/20] merge-ort: fix typos Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 10/20] object-file: fix a typo Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 11/20] pretty: " Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 12/20] read-cache-ll: " Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 13/20] rebase: " Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 14/20] ref-filter: " Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 15/20] refs: fix typos Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 16/20] revision: fix a typo Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 17/20] run-command: " Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 18/20] setup: " Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 19/20] sideband: " Andrew Kreimer via GitGitGadget
2024-09-19 18:34 ` [PATCH 20/20] upload-pack: " Andrew Kreimer via GitGitGadget
2024-09-19 19:35 ` [PATCH 00/20] Fix typos Eric Sunshine
2024-09-20  7:00   ` Andrew Kreimer
2024-09-19 20:33 ` Kristoffer Haugsbakk
2024-09-19 20:42   ` Junio C Hamano [this message]
2024-09-19 20:54     ` Eric Sunshine
2024-09-19 20:57       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq34lv74us.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=algonell@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.