From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] reftable: mark unused parameters in empty iterator functions
Date: Wed, 28 Aug 2024 10:12:22 -0700 [thread overview]
Message-ID: <xmqq34mo1si1.fsf@gitster.g> (raw)
In-Reply-To: <20240828040944.GA4005021@coredump.intra.peff.net> (Jeff King's message of "Wed, 28 Aug 2024 00:09:44 -0400")
Jeff King <peff@peff.net> writes:
> This should go on top of ps/reftable-drop-generic. Arguably this could
> have been done as part of the conflict resolution when merging into next
> alongside jk/mark-unused-parameters, but at this point I think a
> separate patch is the best way forward.
As marking with UNUSED used to be optional before -Wno-unused-param
got removed, I agree that it is better to apply this on top to be
explicit, rather than burying it in an evil merge with a topic that
marked other unrelated parameters as UNUSED.
next prev parent reply other threads:[~2024-08-28 17:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 4:09 [PATCH] reftable: mark unused parameters in empty iterator functions Jeff King
2024-08-28 8:19 ` Patrick Steinhardt
2024-08-28 17:12 ` Junio C Hamano [this message]
2024-08-28 18:10 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq34mo1si1.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.