From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Yukai Chou <muzimuzhi@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH v2] doc: add --show-names for git config
Date: Wed, 21 Aug 2024 09:01:41 -0700 [thread overview]
Message-ID: <xmqq34mx3lwa.fsf@gitster.g> (raw)
In-Reply-To: <ZsWO-K4UFXsG7QNY@tanuki> (Patrick Steinhardt's message of "Wed, 21 Aug 2024 08:53:52 +0200")
Patrick Steinhardt <ps@pks.im> writes:
>> +--show-names::
>> + Output also the names of config variables for `list` or `get`.
>> +
>
> This looks sensible. I'd probably drop the "also" here, which reads a
> bit awkward. Do we also want to spell out how names and values are
> separated from each other?
Sounds like a good thing to add. Thanks.
next prev parent reply other threads:[~2024-08-21 16:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 0:45 [PATCH] doc: add --show-names for git config Yukai Chou
2024-08-19 0:59 ` Yukai Chou
2024-08-19 16:04 ` Junio C Hamano
2024-08-19 18:27 ` [PATCH v2] " Yukai Chou
2024-08-19 19:22 ` Junio C Hamano
2024-08-21 6:53 ` Patrick Steinhardt
2024-08-21 16:01 ` Junio C Hamano [this message]
2024-08-21 6:53 ` [PATCH] " Patrick Steinhardt
2024-08-21 16:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq34mx3lwa.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=muzimuzhi@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.