From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Marcel Telka <marcel@telka.sk>, git@vger.kernel.org
Subject: Re: [PATCH] t/t0211-trace2-perf.sh: fix typo patern -> pattern
Date: Thu, 16 May 2024 08:38:23 -0700 [thread overview]
Message-ID: <xmqq34qhu5qo.fsf@gitster.g> (raw)
In-Reply-To: <ZkWI9--gMH0Xgv3f@tanuki> (Patrick Steinhardt's message of "Thu, 16 May 2024 06:17:59 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> On Thu, May 16, 2024 at 12:51:00AM +0200, Marcel Telka wrote:
>
> Thanks for the patch, which looks obviously good to me. It would be nice
> to have a short explanation in the commit message that explains why this
> issue was able to sneak.
>
> Patrick
A good piece of advice.
FYI, I have the following since last night, as the original report
was whitespace damaged and did not apply.
-------- >8 --------------- >8 --------------- >8 --------
Subject: [PATCH] t0211: typofix
Marcel Telka noticed that one test assigns to $pattern and then
uses $patern in an invocation of "grep". Of course, looking for
an empty string will succeed, so the test succeeds for a wrong
reason.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
t/t0211-trace2-perf.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh
index 0b3436e8ca..37a51e6449 100755
--- a/t/t0211-trace2-perf.sh
+++ b/t/t0211-trace2-perf.sh
@@ -233,7 +233,7 @@ have_counter_event () {
pattern="d0|${thread}|${event}||||${category}|name:${name} value:${value}" &&
- grep "${patern}" ${file}
+ grep "${pattern}" ${file}
}
test_expect_success 'global counter test/test1' '
--
2.45.1-190-g19fe900cfc
prev parent reply other threads:[~2024-05-16 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 22:51 [PATCH] t/t0211-trace2-perf.sh: fix typo patern -> pattern Marcel Telka
2024-05-16 4:17 ` Patrick Steinhardt
2024-05-16 15:38 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq34qhu5qo.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=marcel@telka.sk \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.