All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Kousik Sanagavarapu <five231003@gmail.com>
Cc: Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com>,
	 git@vger.kernel.org
Subject: Re: [Patch] test-lib-functions.sh : change test_i18ngrep to test_grep
Date: Sun, 03 Dec 2023 22:19:34 +0900	[thread overview]
Message-ID: <xmqq34wj4e55.fsf@gitster.g> (raw)
In-Reply-To: <ZWw6r2EDGkpgyYEM@five231003> (Kousik Sanagavarapu's message of "Sun, 3 Dec 2023 13:52:07 +0530")

Kousik Sanagavarapu <five231003@gmail.com> writes:

> Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com> wrote:
>
>> Subject: [Patch] test-lib-functions.sh : change test_i18ngrep to test_grep
>
> For anyone reading the subject, I think reading
>
> 	change test_i18ngrep to test_grep
>
> would be confusing, as from the looks of it, the patch does remove
> test_i18ngrep() and replace it with test_grep (I mean the plan is to
> remove test_i18ngrep only after we are sure that it doesn't exist in the
> code anywhere, anymore) but only making a change in the wording of an
> error message within test_grep().

;-)  

Yes, that was exactly my reaction to the subject (I'm on
vacation so I only scanned the subject lines of incoming patches
without looking at anything else and thought "hmph, it is good
somebody else is cleaning up new uses of test_i18ngrep that have
been introduced by topics simultaneously in flight").

  reply	other threads:[~2023-12-03 13:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-02 17:24 [Patch] test-lib-functions.sh : change test_i18ngrep to test_grep Shreyansh Paliwal
2023-12-03  8:22 ` Kousik Sanagavarapu
2023-12-03 13:19   ` Junio C Hamano [this message]
2023-12-03 17:17 ` [PATCH v2] test-lib-functions.sh: fix test_grep fail message wording Shreyansh Paliwal
2023-12-04 18:43   ` Kousik Sanagavarapu
2023-12-17 15:07   ` Shreyansh Paliwal
2023-12-18  0:51     ` Eric Sunshine
2023-12-18 16:34       ` Junio C Hamano
2023-12-18 18:47         ` Junio C Hamano
2023-12-18 18:55           ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq34wj4e55.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=five231003@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=shreyanshpaliwalcmsmn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.