From: Junio C Hamano <gitster@pobox.com>
To: Josh Steadmon <steadmon@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] setup: trace bare repository setups
Date: Fri, 28 Apr 2023 13:26:23 -0700 [thread overview]
Message-ID: <xmqq354jda8g.fsf@gitster.g> (raw)
In-Reply-To: <ZEv8AcxQW7B2H8uJ@google.com> (Josh Steadmon's message of "Fri, 28 Apr 2023 10:01:53 -0700")
Josh Steadmon <steadmon@google.com> writes:
> On 2023.04.27 15:54, Junio C Hamano wrote:
>> Josh Steadmon <steadmon@google.com> writes:
>>
>> > @@ -22,12 +33,12 @@ test_expect_success 'setup bare repo in worktree' '
>> > '
>> >
>> > test_expect_success 'safe.bareRepository unset' '
>> > - expect_accepted -C outer-repo/bare-repo
>> > + expect_accepted_implicit -C outer-repo/bare-repo
>> > '
>>
>> Perhaps futureproof this test piece by explicitly unsetting the
>> variable before starting the test? That way, this piece will not be
>> broken even if earlier tests gets modified to set some value to
>> safe.bareRepository in the future.
>
> Actually, explicitly setting the variable here is equivalent to the
> following test case, so I'll just remove this one.
I meant explicitly UNsetting, though?
next prev parent reply other threads:[~2023-04-28 20:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 22:32 [PATCH] setup: trace bare repository setups Josh Steadmon
2023-04-27 22:54 ` Junio C Hamano
2023-04-28 16:54 ` Josh Steadmon
2023-04-28 17:01 ` Josh Steadmon
2023-04-28 20:26 ` Junio C Hamano [this message]
2023-05-01 17:20 ` Josh Steadmon
2023-05-08 22:19 ` Glen Choo
2023-04-27 23:36 ` Glen Choo
2023-04-28 16:48 ` Josh Steadmon
2023-04-28 17:22 ` [PATCH v2] " Josh Steadmon
2023-04-28 18:37 ` Glen Choo
2023-05-01 17:22 ` Josh Steadmon
2023-05-01 17:30 ` [PATCH v3] " Josh Steadmon
2023-05-05 22:30 ` Junio C Hamano
2023-05-08 22:31 ` Taylor Blau
2023-05-10 23:29 ` Josh Steadmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq354jda8g.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.