All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Victoria Dye <vdye@github.com>,
	Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH v2] CI: migrate away from deprecated "set-output" syntax
Date: Thu, 08 Dec 2022 08:57:39 +0900	[thread overview]
Message-ID: <xmqq359q6a30.fsf@gitster.g> (raw)
In-Reply-To: <patch-v2-1.1-4e7db0db3be-20221207T014848Z-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Wed, 7 Dec 2022 02:49:18 +0100")

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

>     +-          echo "::set-output name=base::$base"
>     +-          echo "::set-output name=head::$head"
>     ++          cat >>$GITHUB_OUTPUT <<-EOF
>     ++          base=$base
>     ++          head=$head
>     ++          EOF

Hmph, I do not trust this part.

The redirection operator "<<-" causes the leading tabs in the
here-doc-text stripped, but the .yml file does not indent with tab
to begin with.

I suspect the leading spaces will all be stripped and not seen by
the shell, so the distinction may not matter, which means the use of
"<<-" is very much misleading.

Let's stick to the dumb and proven

	echo "base=$base" >>$GITHUB_OUTPUT
	echo "head=$head" >>$GITHUB_OUTPUT

instead, which is used throughout the rewrite in this patch.


  reply	other threads:[~2022-12-07 23:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 20:00 [PATCH] CI: migrate away from deprecated "set-output" syntax Ævar Arnfjörð Bjarmason
2022-12-06 20:50 ` Victoria Dye
2022-12-06 21:08   ` Ævar Arnfjörð Bjarmason
2022-12-07  0:56     ` Taylor Blau
2022-12-07  1:49 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2022-12-07 23:57   ` Junio C Hamano [this message]
2022-12-08  0:27     ` Ævar Arnfjörð Bjarmason
2022-12-08  5:41       ` Junio C Hamano
2022-12-08  0:33   ` [PATCH v3] " Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq359q6a30.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=vdye@github.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.