From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] name-rev: prefer shorter names over following merges
Date: Wed, 17 Nov 2021 00:49:08 -0800 [thread overview]
Message-ID: <xmqq35nv416j.fsf@gitster.g> (raw)
In-Reply-To: nycvar.QRO.7.76.6.2111161227090.21127@tvgsbejvaqbjf.bet
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Thank you. As you most likely figured out, that magic weight was
> introduced by me, in ac076c29ae8 (name-rev: Fix non-shortest description,
> 2007-08-27). And indeed the motivation was to keep the name as short as
> possible.
>
> Technically, your solution does not fix the problem fully, as we still do
> not determine the _shortest possible_ name. Having said that, I think your
> patch improves the situation dramatically, so: ACK!
It really depends on how you define "short". Is v1.0~11 and v1.0~99
the same length and v1.0~100 a bit longer than these two?
I wonder what happens if we counted what the proposed commit log
calls "segments" and nothing else, e.g.
v2.32.0~1471^2 has 2 segments ("~1471", "^2")
v2.32.0~43^2~15^2~11^2~20^2~31^2 has 10 segments
and use number of hops only for breaking ties, instead of giving a
magic weight and trying to count both hops and segments.
In any case, this seems to give us a much better results than the
current code, so let's take it and leave further futzing outside the
scope.
Thanks.
next prev parent reply other threads:[~2021-11-17 8:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 0:14 [PATCH] name-rev: prefer shorter names over following merges Elijah Newren via GitGitGadget
2021-11-13 9:42 ` Ævar Arnfjörð Bjarmason
2021-11-13 19:35 ` Elijah Newren
2021-11-16 12:13 ` Johannes Schindelin
2021-11-17 8:49 ` Junio C Hamano [this message]
2021-12-04 5:35 ` [PATCH v2] " Elijah Newren via GitGitGadget
2021-12-08 11:38 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq35nv416j.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.