From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] t5310: drop lib-bundle.sh include
Date: Fri, 29 Oct 2021 00:04:46 -0700 [thread overview]
Message-ID: <xmqq35okmhv5.fsf@gitster.g> (raw)
In-Reply-To: <YXr3+yqtXYGgaxnX@coredump.intra.peff.net> (Jeff King's message of "Thu, 28 Oct 2021 15:20:27 -0400")
Jeff King <peff@peff.net> writes:
> Commit ddfe900612 (test-lib-functions: move function to lib-bitmap.sh,
> 2021-02-09) meant to include lib-bitmap.sh in t5310, but also includes
> lib-bundle.sh. Yet we don't use any of its functions, nor have anything
> to do with bundles. This is probably just a typo/copy-paste error, as
> lib-bundle.sh was added (correctly) to other scripts in the same series.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> Not really hurting anything, just confusing.
Makes sense to me.
Will queue; thanks.
>
> t/t5310-pack-bitmaps.sh | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/t/t5310-pack-bitmaps.sh b/t/t5310-pack-bitmaps.sh
> index 673baa5c3c..dcf03d324a 100755
> --- a/t/t5310-pack-bitmaps.sh
> +++ b/t/t5310-pack-bitmaps.sh
> @@ -5,7 +5,6 @@ GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master
> export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
>
> . ./test-lib.sh
> -. "$TEST_DIRECTORY"/lib-bundle.sh
> . "$TEST_DIRECTORY"/lib-bitmap.sh
>
> # t5310 deals only with single-pack bitmaps, so don't write MIDX bitmaps in
next prev parent reply other threads:[~2021-10-29 7:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 19:20 [PATCH] t5310: drop lib-bundle.sh include Jeff King
2021-10-29 7:04 ` Junio C Hamano [this message]
2021-10-29 10:16 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq35okmhv5.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.