From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: ZheNing Hu via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org,
Christian Couder <christian.couder@gmail.com>,
Hariom Verma <hariom18599@gmail.com>,
ZheNing Hu <adlternative@gmail.com>
Subject: Re: [PATCH] [GSOC] cat-file: fix --batch report changed-type bug
Date: Tue, 01 Jun 2021 10:40:38 +0900 [thread overview]
Message-ID: <xmqq35u2uzu1.fsf@gitster.g> (raw)
In-Reply-To: <YLQFRU2avYFBfdPu@coredump.intra.peff.net> (Jeff King's message of "Sun, 30 May 2021 17:36:05 -0400")
Jeff King <peff@peff.net> writes:
> On Mon, May 31, 2021 at 06:15:00AM +0900, Junio C Hamano wrote:
>
>> There however is one curious thing about this. The log message of
>> the original commit that introduced this optimization does use the
>> batch-check and batch-all-objects at the same time. Was this
>> breakage not there when the original was written and we broke it in
>> a later update? If so, with what commit? Can that commit have
>> broken other places in cat-file in a similar manner?
>
> The subtlety here is that it is broken with --batch, not --batch-check.
> Only the former calls print_object_or_die(), which is after all the
> difference between the two. :)
>
>> [...]
>
> Everything else you noted was quite reasonable, but I think we can get
> further at the root of the issue; see my other email.
Yup, I missed the place we depend on type being set without
checking.
next prev parent reply other threads:[~2021-06-01 1:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-30 8:29 [PATCH] [GSOC] cat-file: fix --batch report changed-type bug ZheNing Hu via GitGitGadget
2021-05-30 21:09 ` Jeff King
2021-05-31 13:20 ` ZheNing Hu
2021-05-31 14:44 ` Jeff King
2021-05-31 15:32 ` ZheNing Hu
2021-05-31 16:07 ` Felipe Contreras
2021-06-01 1:49 ` Jeff King
2021-06-01 6:34 ` Felipe Contreras
2021-06-01 15:34 ` Jeff King
2021-06-01 16:42 ` Felipe Contreras
2021-06-01 12:46 ` ZheNing Hu
2021-05-30 21:15 ` Junio C Hamano
2021-05-30 21:36 ` Jeff King
2021-06-01 1:40 ` Junio C Hamano [this message]
2021-05-31 13:55 ` ZheNing Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq35u2uzu1.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=adlternative@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=hariom18599@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.