From: Junio C Hamano <gitster@pobox.com>
To: "Jakub Narębski" <jnareb@gmail.com>
Cc: Lars Schneider <larsxschneider@gmail.com>,
Eric Wong <e@80x24.org>,
git@vger.kernel.org
Subject: Re: RFC: Enable delayed responses to Git clean/smudge filter requests
Date: Wed, 16 Nov 2016 15:46:25 -0800 [thread overview]
Message-ID: <xmqq37irouni.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <5eb682e8-13cb-67f2-a8a9-ec1fa1d139c6@gmail.com> ("Jakub Narębski"'s message of "Wed, 16 Nov 2016 23:41:57 +0100")
Jakub Narębski <jnareb@gmail.com> writes:
>> I intend to implement this feature only for the new long running filter
>> process protocol. OK with you?
>
> If I remember and understand it correctly, current version of long
> running process protocol processes files sequentially, one by one:
> git sends file to filter wholly, and receives response wholly.
>
> In the single-file filter case, git calls filter process as async
> task, in a separate thread, so that one thread feeds the filter,
> and main thread (I think?) reads from it, to avoid deadlocks.
>
> Couldn't something like this be done for long running filter process,
> via protocol extension?
My reading of the message you are responding to is that Lars means
doing so by "implement this feature". Instead of returning the
filtered bytes, a new protocol lets his filter to say "No result yet
for you to process, ask me later".
next prev parent reply other threads:[~2016-11-16 23:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 21:09 RFC: Enable delayed responses to Git clean/smudge filter requests Lars Schneider
2016-11-15 1:03 ` Eric Wong
2016-11-15 14:29 ` Lars Schneider
2016-11-15 18:03 ` Junio C Hamano
2016-11-16 9:53 ` Lars Schneider
2016-11-16 18:15 ` Junio C Hamano
2016-11-16 18:47 ` Lars Schneider
2016-11-16 19:19 ` Junio C Hamano
2016-11-16 22:41 ` Jakub Narębski
2016-11-16 23:46 ` Junio C Hamano [this message]
2016-11-17 9:19 ` Lars Schneider
2016-11-24 15:45 ` Lars Schneider
2016-11-28 21:48 ` Junio C Hamano
2016-11-15 18:27 ` Eric Wong
2017-01-09 20:44 ` Stefan Beller
2017-01-11 12:57 ` Lars Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq37irouni.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=larsxschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.