All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Jakub Narębski" <jnareb@gmail.com>
Cc: Mike Hommey <mh@glandium.org>,
	Johannes Schindelin <johannes.schindelin@gmx.de>,
	git@vger.kernel.org
Subject: Re: [PATCH] am: counteract gender bias
Date: Thu, 07 Jul 2016 09:04:33 -0700	[thread overview]
Message-ID: <xmqq37nlqvse.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: 577E580B.5090000@gmail.com

Jakub Narębski <jnareb@gmail.com> writes:

> Also, in all (?) other places we use "ours" and "theirs"; it looks like
> git-am was a strange exception with "ours" and "his" (also, it was/is
> inconsistent in using plural vs singular form).  Though perhaps it was
> created before the terminology solidified...

I also thought that "ours" vs "his" was strange mixture of plural
and singular when I first saw it, but it turns out there was no
mixture.

It originates at 47f0b6d5 (Fall back to three-way merge when
applying a patch., 2005-10-06), where the code used $his_tree and
$orig_tree, (there was no reference to "our" tree), both singular.
They were copied to "git am" introduced at d1c5f2a4 (Add git-am,
applymbox replacement., 2005-10-07) almost verbatim.

The use of "ours" & "theirs" is now established, and I agree with
you that the use of "his" that is contained to the fall_back_3way
helper function (cf. contrib/examples/git-am.sh) is an oddball.

We should just use "theirs" to be consistent from the beginning, as
you suggested.  There is no need to churn the codebase for political
correctness to first use "hers" that everybody knows will *not* be
the final form.

  parent reply	other threads:[~2016-07-07 16:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07 11:47 [PATCH] am: counteract gender bias Johannes Schindelin
2016-07-07 12:49 ` Mike Hommey
2016-07-07 13:24   ` Jakub Narębski
2016-07-07 14:17     ` Johannes Schindelin
2016-07-07 16:04     ` Junio C Hamano [this message]
2016-07-08  7:08       ` Johannes Schindelin
2016-07-07 14:12   ` Johannes Schindelin
2016-07-08  7:17 ` [PATCH v2] " Johannes Schindelin
2016-07-08  7:50   ` Jakub Narębski
2016-07-08 21:39   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq37nlqvse.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=mh@glandium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.