All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: larsxschneider@gmail.com, git@vger.kernel.org,
	johannes.schindelin@gmx.de, tboegi@web.de, pw@padd.com
Subject: Re: [PATCH v3 1/3] Add Travis CI support
Date: Mon, 12 Oct 2015 09:02:35 -0700	[thread overview]
Message-ID: <xmqq37xgnkh0.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <561B69AE.8050403@gmail.com> (Sebastian Schuberth's message of "Mon, 12 Oct 2015 10:05:02 +0200")

Sebastian Schuberth <sschuberth@gmail.com> writes:

> Semantically, it does not seem correct to me that configuarion goes to
> the install step. As "make test" will build git anyway, I'd instead
> propose to get rid of "install" and just say:
>
> before_script: make configure && ./configure
>
> script: make --quiet test

Very good point.  Do we even need to do anything in the "install"
target?  We aim to be able to testable without any installed Git,
and not running "make install" at all, ever, would be one way to
make sure that works.

This is a slightly related tangent, but we saw a few build issues
reported recently on customized configurations like NO_PTHREAD.  If
we are to start using automated tests, I wonder if we want to build
(and optionally test) with various combinations of the customization
options (e.g. NO_CURL, NO_OPENSSL, NO_MMAP, NO_IPV6, NO_PERL etc.)

Thanks.

  reply	other threads:[~2015-10-12 16:02 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-11 17:54 [PATCH v3 0/3] Add Travis CI support larsxschneider
2015-10-11 17:55 ` [PATCH v3 1/3] " larsxschneider
2015-10-11 20:40   ` Eric Sunshine
2015-10-12 16:46     ` Lars Schneider
2015-10-12  8:05   ` Sebastian Schuberth
2015-10-12 16:02     ` Junio C Hamano [this message]
2015-10-12 18:42       ` Sebastian Schuberth
2015-10-12 19:40       ` Lars Schneider
2015-10-12 19:48         ` Sebastian Schuberth
2015-10-12 20:10         ` Matthieu Moy
2015-10-12 17:12     ` Lars Schneider
2015-10-12 19:37       ` Sebastian Schuberth
2015-10-12 19:43         ` Lars Schneider
2015-10-12 19:53           ` Sebastian Schuberth
2015-10-12 20:20   ` Matthieu Moy
2015-10-14 22:52     ` Lars Schneider
2015-10-15  8:07       ` Matthieu Moy
2015-10-15  9:02       ` Jean-Noël Avila
2015-10-13 10:32   ` Jean-Noël Avila
2015-10-15  7:59     ` Lars Schneider
2015-10-15  8:12       ` Matthieu Moy
2015-10-15 10:35         ` Lars Schneider
2015-10-15 10:50         ` Johannes Schindelin
2015-10-15 17:14           ` Matthieu Moy
2015-10-11 17:55 ` [PATCH v3 2/3] git-p4: Improve test case portability for t9815 git-p4-submit-fail larsxschneider
2015-10-11 17:55 ` [PATCH v3 3/3] git-p4: Skip t9819 test case on case insensitive file systems larsxschneider
2015-10-12  6:47   ` Luke Diamand
2015-10-12 16:07 ` [PATCH v3 0/3] Add Travis CI support Junio C Hamano
2015-10-12 16:07 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq37xgnkh0.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=larsxschneider@gmail.com \
    --cc=pw@padd.com \
    --cc=sschuberth@gmail.com \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.