All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
	git@vger.kernel.org, luke@diamand.org, pw@padd.com,
	torarvid@gmail.com, ksaitoh560@gmail.com
Subject: Re: [PATCH v2] git-p4: fix faulty paths for case insensitive systems
Date: Thu, 20 Aug 2015 08:55:35 -0700	[thread overview]
Message-ID: <xmqq37ze7y4o.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <917E3751-4BC8-4034-9101-30C77426D81C@gmail.com> (Lars Schneider's message of "Thu, 20 Aug 2015 09:16:39 +0200")

Lars Schneider <larsxschneider@gmail.com> writes:

>>> +		find . | grep TWO/file1.txt &&
>>> +		find . | grep TWO/File2.txt &&
>>> +		find . | grep TWO/file3.txt &&
>> Not sure about the find | grep here either.
> See answers above.

These are not very good tests; they will match "OTWO/file1.txto",
too.  Besides, it is wasteful to run find three times.

        find ?* -print | sort >actual &&
        cat >expect <<-\EOF &&
        TWO/file1.txt
        ...
        EOF
	test_cmp expect actual

or something like that instead?

  parent reply	other threads:[~2015-08-20 15:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19 20:04 [PATCH v2] git-p4: fix faulty paths for case insensitive systems larsxschneider
2015-08-19 20:04 ` larsxschneider
2015-08-20  4:59   ` Torsten Bögershausen
2015-08-20  7:16     ` Lars Schneider
2015-08-20 13:17       ` Eric Sunshine
2015-08-20 15:55       ` Junio C Hamano [this message]
2015-08-21  8:08         ` Lars Schneider
2015-08-21  8:10           ` Eric Sunshine
2015-08-20 19:02       ` Torsten Bögershausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq37ze7y4o.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ksaitoh560@gmail.com \
    --cc=larsxschneider@gmail.com \
    --cc=luke@diamand.org \
    --cc=pw@padd.com \
    --cc=tboegi@web.de \
    --cc=torarvid@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.