From: Junio C Hamano <gitster@pobox.com>
To: Trevor Saunders <tbsaunde@tbsaunde.org>
Cc: git@vger.kernel.org, Jens Lehmann <Jens.Lehmann@web.de>,
Heiko Voigt <hvoigt@hvoigt.net>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH, RFC] checkout: Attempt to checkout submodules
Date: Thu, 19 Mar 2015 14:15:19 -0700 [thread overview]
Message-ID: <xmqq3850it94.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150319201509.GB21536@tsaunders-iceball.corp.tor1.mozilla.com> (Trevor Saunders's message of "Thu, 19 Mar 2015 16:15:09 -0400")
Trevor Saunders <tbsaunde@tbsaunde.org> writes:
> On one hand it seems kind of user hostile to just toss out any changes
> in the submodule that are uncommitted, on the other for any other path
> it would seem weird to have git checkout trigger rebasing or merging.
I think that is exactly why we do not do anything in this codepath.
I have a feeling that an optional feature that allows "git submodule
update" to happen automatically from this codepath might be
acceptable by the submodule folks, and they might even say it does
not even have to be optional but should be enabled by default.
But I do not think it would fly well to unconditionally run
"checkout -f" here.
next prev parent reply other threads:[~2015-03-19 21:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 12:27 [PATCH, RFC] checkout: Attempt to checkout submodules Trevor Saunders
2015-03-19 18:53 ` Junio C Hamano
2015-03-19 20:15 ` Trevor Saunders
2015-03-19 21:15 ` Junio C Hamano [this message]
2015-03-20 0:13 ` Trevor Saunders
2015-03-23 20:01 ` Jens Lehmann
2015-03-24 18:30 ` Trevor Saunders
2015-03-25 20:16 ` Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq3850it94.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=jrnieder@gmail.com \
--cc=tbsaunde@tbsaunde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.