All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 5/6] t/diff-lib: check exact object names in compare_diff_raw
Date: Mon, 23 Feb 2015 11:45:30 -0800	[thread overview]
Message-ID: <xmqq385wtns5.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <54EB6E17.5040102@kdbg.org> (Johannes Sixt's message of "Mon, 23 Feb 2015 19:14:47 +0100")

Johannes Sixt <j6t@kdbg.org> writes:

>> diff --git a/t/diff-lib.sh b/t/diff-lib.sh
>> index 75a35fc..c211dc4 100644
>> --- a/t/diff-lib.sh
>> +++ b/t/diff-lib.sh
>> @@ -1,6 +1,6 @@
>>   :
>>   
>> -sanitize_diff_raw='/^:/s/ '"$_x40"' '"$_x40"' \([A-Z]\)[0-9]*	/ X X \1#	/'
>> +sanitize_diff_raw='/^:/s/ '"\($_x40\)"' '"\($_x40\)"' \([A-Z]\)[0-9]*	/ \1 \2 \3#	/'
>>   compare_diff_raw () {
>>       # When heuristics are improved, the score numbers would change.
>>       # Ignore them while comparing.
>> 
>
> This reveals a minor bug in test_ln_s_add:

Thanks for catching it before it hits 'master'.

  reply	other threads:[~2015-02-23 19:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-15 23:43 [PATCH 0/6] test updates around diff Junio C Hamano
2015-02-15 23:43 ` [PATCH 1/6] t4008: correct stale comments Junio C Hamano
2015-02-15 23:43 ` [PATCH 2/6] t9300: correct expected object names Junio C Hamano
2015-02-15 23:43 ` [PATCH 3/6] t4010: " Junio C Hamano
2015-02-15 23:43 ` [PATCH 4/6] tests: do not borrow from COPYING and README from the real source Junio C Hamano
2015-02-15 23:43 ` [PATCH 5/6] t/diff-lib: check exact object names in compare_diff_raw Junio C Hamano
2015-02-23 18:14   ` Johannes Sixt
2015-02-23 19:45     ` Junio C Hamano [this message]
2015-02-15 23:43 ` [PATCH 6/6] t4008: modernise style Junio C Hamano
2015-02-16  6:23 ` [PATCH 0/6] test updates around diff Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq385wtns5.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.