All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Thomas Quinot <thomas@quinot.org>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH v2 1/2] git_connect: set ssh shell command in GIT_SSH_CMD
Date: Sun, 09 Nov 2014 09:32:30 -0800	[thread overview]
Message-ID: <xmqq389se0up.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141109123934.GA50956@melamine.cuivre.fr.eu.org> (Thomas Quinot's message of "Sun, 9 Nov 2014 13:39:34 +0100")

Thomas Quinot <thomas@quinot.org> writes:

> Could also be GIT_SSH_SHELLCMD, to denote that this is a *shell*
> command...

Whatever.  I loathe the CMD abbreviation, though.  Why spell out
SHELL but not COMMAND?  I.e. GIT_SSH_[SHELL_]COMMAND

>> Parsing complications aside, you cannot even know in git which ssh is
>> going to be run until the shell code is executed. I think either we have
>> to leave the responsibility for munging "-p" into "-P" on the side of
>> the user's shell snippet
>
> That sounds like a reasonable approach, and leaves us with the simpler
> change (that splitting circuitry was admittely a bit awkward...)

It does not make sense to special case "plink" at the level of this
mechanism where the spawned command line does not even have to
invoke any "ssh" and its derivatives, so I fully agree that choosing
between -P and -p should be the responsibility of whoever is using
this mechanism.

Thanks.

  parent reply	other threads:[~2014-11-09 17:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-08 10:44 [PATCH] git_connect: allow passing arguments to ssh in GIT_SSH_ARGS Thomas Quinot
2014-11-08 11:09 ` Jeff King
2014-11-08 12:35   ` Thomas Quinot
2014-11-08 14:27     ` [PATCH v2 1/2] git_connect: set ssh shell command in GIT_SSH_CMD Thomas Quinot
2014-11-09  9:51       ` Jeff King
2014-11-09 12:39         ` Thomas Quinot
2014-11-09 13:24           ` [PATCH v3] " Thomas Quinot
2014-11-09 17:32           ` Junio C Hamano [this message]
2014-11-09 17:47             ` [PATCH v2 1/2] " Thomas Quinot
2014-11-09 17:58               ` Junio C Hamano
2014-11-09 22:42                 ` [PATCH v4] git_connect: set ssh shell command in GIT_SSH_COMMAND Thomas Quinot
2014-11-10  7:11                   ` Jeff King
2014-11-10  8:28                     ` Thomas Quinot
2014-11-10 16:54                       ` Junio C Hamano
2014-11-08 14:29     ` [PATCH v2 2/2] git_connect: when using GIT_SSH_CMD, check for plink in argv[0] only Thomas Quinot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq389se0up.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=thomas@quinot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.