From: Junio C Hamano <gitster@pobox.com>
To: "Keller\, Jacob E" <jacob.e.keller@intel.com>
Cc: "peff\@peff.net" <peff@peff.net>,
"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH v2] tag: support configuring --sort via .gitconfig
Date: Thu, 10 Jul 2014 15:46:04 -0700 [thread overview]
Message-ID: <xmqq38e87ryr.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1405029028.4925.32.camel@jekeller-desk1.amr.corp.intel.com> (Jacob E. Keller's message of "Thu, 10 Jul 2014 21:50:29 +0000")
"Keller, Jacob E" <jacob.e.keller@intel.com> writes:
> On Thu, 2014-07-10 at 15:34 -0400, Jeff King wrote:
>> On Thu, Jul 10, 2014 at 10:59:36AM -0700, Junio C Hamano wrote:
>>
>> > Jeff King <peff@peff.net> writes:
>> >
>> > > I know this is existing code you are moving, but I noticed it looks ripe
>> > > for using skip_prefix. Perhaps while we are in the area we should do the
>> > > following on top of your patch (I'd also be happy for it be squashed
>> > > in, but that may be too much in one patch).
>> >
>> > I am tempted to suggest going the other way around, i.e. queue (an
>> > equivalent of) this on jk/skip-prefix and merge it to 'next' and
>> > then 'master' quickly.
>> >
>> > I can go either way, but I tend to prefer building new things on top
>> > of obviously correct clean-up, not the other way around.
>>
>> Me too. I just didn't want to make more work for Jacob (in having to
>> rebase on top of mine) or for you (in having to do a non-obvious merge a
>> few days from now).
>>
>> -Peff
>
> I'm perfectly fine rebasing. :)
Alright, thanks.
I am still not ready to push out today's integration result, but
when it happens, Peff's "tag: use skip_prefix" should appear at
ce85604, as a direct follow-up to the tip of already merged
jk/skip-prefix topic which was 67a31f61 (http-push: refactor parsing
of remote object names, 2014-06-19).
next prev parent reply other threads:[~2014-07-10 22:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 22:36 [PATCH v2] tag: support configuring --sort via .gitconfig Jacob Keller
2014-07-10 4:00 ` Jeff King
2014-07-10 4:07 ` Jeff King
2014-07-10 17:59 ` Junio C Hamano
2014-07-10 19:34 ` Jeff King
2014-07-10 21:50 ` Keller, Jacob E
2014-07-10 22:46 ` Junio C Hamano [this message]
2014-07-10 20:38 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq38e87ryr.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.