From: Junio C Hamano <gitster@pobox.com>
To: Caleb Thompson <caleb@calebthompson.io>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Jeremiah Mahler <jmmahler@gmail.com>
Subject: Re: [PATCH v6 1/4] commit test: Use test_config instead of git-config
Date: Tue, 17 Jun 2014 14:35:51 -0700 [thread overview]
Message-ID: <xmqq38f3kymg.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqq8uovkytq.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Tue, 17 Jun 2014 14:31:29 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Caleb Thompson <caleb@calebthompson.io> writes:
>
>> Some of the tests in t/t7507-commit-verbose.sh were still using
>> git-config to set configuration. Change them to use the test_config
>> helper.
>
> "were still using" is only a half of the story, and we need to be
> more careful than that, though.
I'd rephrase it like so if I were doing this patch myself:
Subject: t7507: use test_config instead of git-config
Some of the tests in t/t7507-commit-verbose.sh uses git-config
to set configuration, but the updated variable setting does not
have to be used in later tests.
Change them to use the test_config helper.
next prev parent reply other threads:[~2014-06-17 21:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 19:38 [PATCH v6 0/4] commit: Add commit.verbose configuration Caleb Thompson
2014-06-17 19:38 ` [PATCH v6 1/4] commit test: Use test_config instead of git-config Caleb Thompson
2014-06-17 21:31 ` Junio C Hamano
2014-06-17 21:35 ` Junio C Hamano [this message]
2014-06-17 19:38 ` [PATCH v6 2/4] commit test: Use write_script Caleb Thompson
2014-06-17 19:38 ` [PATCH v6 3/4] commit test: test_set_editor in each test Caleb Thompson
2014-06-17 19:39 ` [PATCH v6 4/4] commit: Add commit.verbose configuration Caleb Thompson
2014-06-17 21:21 ` Jeff King
2014-06-17 21:37 ` Junio C Hamano
2014-06-17 21:39 ` Jeff King
2015-02-27 9:13 ` [PATCH v6 0/4] " Torstein Hegge
2015-03-02 19:02 ` Caleb Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq38f3kymg.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=caleb@calebthompson.io \
--cc=git@vger.kernel.org \
--cc=jmmahler@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.