From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Christian Couder <chriscool@tuxfamily.org>,
git@vger.kernel.org, Avery Pennarun <apenwarr@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Jeff King <peff@peff.net>, Max Horn <max@quendi.de>
Subject: Re: [PATCH v3 2/2] Rename suffixcmp() to has_suffix() and invert its result
Date: Wed, 06 Nov 2013 16:12:51 -0800 [thread overview]
Message-ID: <xmqq38n96pdo.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20131106221735.GB10302@google.com> (Jonathan Nieder's message of "Wed, 6 Nov 2013 14:17:35 -0800")
Jonathan Nieder <jrnieder@gmail.com> writes:
>> The old name followed the pattern anything-cmp(), which suggests
>> a general comparison function suitable for e.g. sorting objects.
>> But this was not the case for suffixcmp().
>
> It's not clear to me that prefixcmp() is usable for sorting objects,
> either. Shouldn't it get the same treatment?
Sounds like a plan for a good follow-up series.
> If some day we invent a type for 4-byte-aligned object names, it might
> make sense to do something similar to hashcmp, distinguishing between
> hashcmp for use where ordering is important and something like hash_eq
> when checking for equality (since I suspect the latter can be made
> faster).
Interesting.
next prev parent reply other threads:[~2013-11-07 0:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 21:02 [PATCH v3 2/2] Rename suffixcmp() to has_suffix() and invert its result Christian Couder
2013-11-06 22:17 ` Jonathan Nieder
2013-11-06 22:56 ` Max Horn
2013-11-06 23:28 ` Jonathan Nieder
2013-11-06 23:53 ` Max Horn
2013-11-07 0:12 ` Junio C Hamano [this message]
2013-11-07 11:04 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq38n96pdo.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=apenwarr@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=max@quendi.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.