All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Aniket Gupta <aniketgupta3001@gmail.com>,
	 git@vger.kernel.org, christian.couder@gmail.com,  cat@malon.dev,
	 belkid98@gmail.com, phillip.wood123@gmail.com
Subject: Re: [PATCH 0/4] environment: move line ending config variables into repo_config_values
Date: Mon, 26 Oct 2026 08:53:57 -0700	[thread overview]
Message-ID: <xmqq4ie8tq3u.fsf@gitster.g> (raw)
In-Reply-To: <at9HOXZhVcl53CGX@pks.im> (Patrick Steinhardt's message of "Mon, 26 Oct 2026 13:27:37 +0100")

Patrick Steinhardt <ps@pks.im> writes:

> While these patches _look_ like they libify Git more, they actually do
> the exact opposite right now and tie us more and more to
> `the_repository`. So I'm inclined to say that we should hold off merging
> these patches until we fix that issue, or otherwise we paint ourselves
> into a corner.

Could you please volunteer to add a quick patch to add a comment
next to the problematic structure to tell people stop moving things
there (for now) and point at the message I am responding to?

Thanks.

      parent reply	other threads:[~2026-10-26 15:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24 22:00 [PATCH 0/4] environment: move line ending config variables into repo_config_values Aniket Gupta
2026-10-24 22:00 ` [PATCH 1/4] convert: pass 'repo' to the working tree conversion functions Aniket Gupta
2026-10-24 22:00 ` [PATCH 2/4] environment: move auto_crlf into repo_config_values Aniket Gupta
2026-10-24 22:00 ` [PATCH 3/4] environment: move core_eol " Aniket Gupta
2026-10-24 22:00 ` [PATCH 4/4] environment: move global_conv_flags_eol " Aniket Gupta
2026-10-26 12:27 ` [PATCH 0/4] environment: move line ending config variables " Patrick Steinhardt
2026-10-26 13:10   ` Aniket Gupta
2026-10-26 13:25     ` Patrick Steinhardt
2026-10-26 15:53   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4ie8tq3u.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=aniketgupta3001@gmail.com \
    --cc=belkid98@gmail.com \
    --cc=cat@malon.dev \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=phillip.wood123@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.