From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b4-smtp.messagingengine.com (fout-b4-smtp.messagingengine.com [202.12.124.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C2372DAFBD for ; Wed, 8 Jul 2026 20:16:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783541766; cv=none; b=nglsDkFNm538PweeAuR52GlUqbcJOPzaQhiuCXUzr+uUfZPBamLr4bFRP7dFcEcHwwlgtmkVJBkiQH3xy6nlbheWkL0jNFaQpTqKMl3o/cudGmmUxw/S7Chh14XTIW/oh9UWrxSrttCPTn5w348Yww+wB6im+B14N6Ua/yxGdfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783541766; c=relaxed/simple; bh=FWl4dgz+tyv8qJsnzVys/i7G7+HSvGyt6EdwvcolI30=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=kHcdgCHNew7D2AbEiy5CvG0BoUUtXmfs+chfq5wa2NF3NkgTAkjR0GHpYCEG76s16Ubdgn6xXPw6zv5LkTz9nSQ5ZENYnCS5o/gEgd32gV0Kp7FGiuO3roxholEuE5nPwDbhJ9H/j5XD4omOIn0/pCBSf7RPXTr3LDIaWja8ibY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b=KBZZ6qkf; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=eBLr8LZB; arc=none smtp.client-ip=202.12.124.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b="KBZZ6qkf"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="eBLr8LZB" Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfout.stl.internal (Postfix) with ESMTP id 9899E1D00142; Wed, 8 Jul 2026 16:16:04 -0400 (EDT) Received: from phl-frontend-02 ([10.202.2.161]) by phl-compute-01.internal (MEProxy); Wed, 08 Jul 2026 16:16:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1783541764; x=1783628164; bh=erdCYzqp6G 01ahKr46TBQJWqMSA8R6zIWMawghU1i3M=; b=KBZZ6qkfS8mN6kdEnp41h9+/uR AH4I7WykOqeuh8AuKgB2iY96knwnXgfvKkWTmJFW1Eh8G9pf/mWfRS8aBflylE/Q DGWQajyXKFdGeuOwtQSUISSHTN4JwB3szlVoDIQRIQWbWIOjtXDfVSCrCROy/Ay0 1FbM3qUBGArlh2SFN2ACmBo85DEM7uecvMLf0b9F61XknwTx58dacrAVNbCx5/Qn oiRRJ8ULQB53Cm4l/X92MLV3tKdzgiuaWPfW4VSW0fFK2J1yRRJq6OpZPPKBby1M VdUBNBJR4VzMncPgj6OgCW1wI4ONjY6nlblcDC6hINRGy1OoQ5AOpSvyyOMQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1783541764; x=1783628164; bh=erdCYzqp6G01ahKr46TBQJWqMSA8R6zIWMa wghU1i3M=; b=eBLr8LZB6PEugo41MV65ruXzSP/EA+Ikjt0HkTYT1cV9VEWNxHa ib42xkFm9S/h45Fd5pJFltCkiWxzrb9KZ6l8FHwiXK9C/3tHQn97Yek3a3mhiP3Z RAB4K514YT9J0mIEqImWoS/KJgKS+QFsB/859XbQr80ngq02CyXXVDVGIrxP057M 2VU2LIkjRCcsnq0R9yOeXyjBdR2fcLBwUiTOxXtM5a95oBCjYW1bVPpOj5Z0a40b R1oHlmjBk+66K/W7LLPc/bUS2oGUiCpMtio3WGDoTexg9KHVW1IESQR2/dvl9aA4 fDk71rx1sqXGnDhpugHZxuGlgJFVfYyOq2Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFVnvyKCOi+6asCBnRvBghry4vfYec4WKsdVqLfXxe66TY18V8+wBcq08QMNgraOW ZCN1im7lfSopki5Qwih6lnii5GMXL/CSUD15/sGvyiR02XvEJrl3wq02kTtXCVhY/L7doS geKUbpIgg2qnT1O25wigCcruzTuqgL89C6Y1uHpsWf+/MkbjAtY9o7njrz55CH/lbR4Boe fiyTD8bYph4PSYriATZZx2qE9BlH5aDDu2sm+sSFWnqdheDrUqGHH3Pimv/flWEW7LsW9k wQqvmHzaKn8fniFChxRzBcIyLB5eRvoQo/T9S8tS7unWpoZBDAn2Q+0ceRvJPt7WQ1q4SV AQDOvWZ0V/AVVRUY9mM5EzVqPh4K64pipYvh2ThdOQ2Bo16/XKtiuGiSVq8pOh5lnPCuHs 7XrUQcJNpL5e+Ouv1VO8b6MitnsRwZUS76RIXlCjli3GLrKnFDLJ2kpUp66gcxOW13enTL JvwZZvkukwp0TRtZAUKOYRojIBW334wy6FdYPzBApCyhbenAJVsvKFw3VNfxdRpBVzQpIx wWFA821JFA3Qo6dZcpWDlTeNQWXlorboHQ6jYz83aYMyenCVBZGSDTgXcn3Ss6djfpUClp sykTzydBDHs87O7oz0uaSXzDBnKGwiabH4ywxpjChRV5PVDg+rhtU/hyVt6g X-ME-Proxy: Feedback-ID: if26b431b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Jul 2026 16:16:03 -0400 (EDT) From: Junio C Hamano To: "Shardul Natu via GitGitGadget" Cc: git@vger.kernel.org, Kristoffer Haugsbakk , Shardul Natu , Koji Nakamaru , Patrick Steinhardt , Shardul Natu , Ben Knoble Subject: Re: [PATCH v8 0/3] Makefile: link osxkeychain helper against Rust In-Reply-To: (Shardul Natu via GitGitGadget's message of "Wed, 08 Jul 2026 03:21:16 +0000") References: Date: Wed, 08 Jul 2026 13:16:01 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Shardul Natu via GitGitGadget" writes: > Changes since v7: > > * Added inclusion of ../config.mak.uname to the top of contrib/Makefile in > the canonical order. This guarantees that $(uname_S) is correctly defined > on the shell, preventing the OS_CONTRIB additions from being silently > ignored. This round of patches looked good to me (even though I am not a macOS user, so my review only goes on the surface without actual testing).