From: Junio C Hamano <gitster@pobox.com>
To: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
Cc: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
"Aaron Plattner" <aplattner@nvidia.com>,
git@vger.kernel.org, "Patrick Steinhardt" <ps@pks.im>
Subject: Re: [PATCH] odb: do not use "blank" substitute for NULL
Date: Fri, 19 Dec 2025 21:25:17 +0900 [thread overview]
Message-ID: <xmqq4ipmwtea.fsf@gitster.g> (raw)
In-Reply-To: <4d084712-dc9a-4824-b840-4d78831d9da9@app.fastmail.com> (Kristoffer Haugsbakk's message of "Fri, 19 Dec 2025 08:39:31 +0100")
"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
> On Thu, Dec 18, 2025, at 11:59, Carlo Marcelo Arenas Belón wrote:
>> On Thu, Dec 18, 2025 at 09:02:59AM -0800, Kristoffer Haugsbakk wrote:
>>>[snip]
>>>
>>> This project typically does not use that trailer/tag.
>>
>> While factually correct, I think the "why" is more interesting in this case.
>> anf the answer IMHO is: not, because it is not needed.
>>
>> % git describe 385e18810f10
>> v2.52.0-25-g385e18810f
>>
>> shows that this bug is only present after 2.52.0 was released so unless you
>> are using unreleased version of git (ex: some development version, including
>> ones that are based on "next"), there is no need to "backport" this fix, as
>> the next version you will use will include it.
>
> So the Linux Kernel (presumably) uses `Fixes` for backporting and/or
> does *not* use it for commits that fix changes that have not been
> released yet. Got it.
I do not run, and I am not involved in, the Linux Kernel project. I
am not sure if "is this fix something backporting folks should care
about?" is the criterion they use in their project, but if it is, I
think it does make a certain sense.
I have mentioned my displeasure with use of "Fixes" in _this_
project before, but that was primarily based on the fact that you do
not really know if a proposed commit really fixes or makes something
else worse until your alleged "fix" cooks sufficiently long in the
field, and I find it distasteful to make such an unsure thing easier
to mechanically process.
Thanks.
next prev parent reply other threads:[~2025-12-19 12:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 3:35 [PATCH] odb: do not use "blank" substitute for NULL Junio C Hamano
2025-12-18 4:51 ` Aaron Plattner
2025-12-18 8:02 ` Kristoffer Haugsbakk
2025-12-18 10:59 ` Carlo Marcelo Arenas Belón
2025-12-19 7:39 ` Kristoffer Haugsbakk
2025-12-19 12:25 ` Junio C Hamano [this message]
2025-12-18 6:31 ` Patrick Steinhardt
2025-12-18 8:50 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4ipmwtea.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=aplattner@nvidia.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.