All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: <git@vger.kernel.org>,  Jacob Keller <jacob.keller@gmail.com>,
	 "Patrick Steinhardt" <ps@pks.im>
Subject: Re: [PATCH 0/6] submodule: improve remote lookup logic
Date: Tue, 17 Jun 2025 08:09:28 -0700	[thread overview]
Message-ID: <xmqq4iwexv4n.fsf@gitster.g> (raw)
In-Reply-To: <83af9bc9-7884-4ce8-a343-28dbcded7954@intel.com> (Jacob Keller's message of "Mon, 16 Jun 2025 16:20:33 -0700")

Jacob Keller <jacob.e.keller@intel.com> writes:

> On 6/16/2025 3:41 PM, Junio C Hamano wrote:
>> Jacob Keller <jacob.e.keller@intel.com> writes:
>> 
>>> Seems like there hasn't been any interest in this series? :(
>> 
>> So far it seems, but we have been in pre-release freeze for a few
>> weeks combined with slower summer (in northern hemisphere anyway)
>> season, so it might have just been a bad timing.
>
> Oh true. I can resend once release freeze ends :)

Before doing so, can you run with leaksanitizer?  When merged to
'jch', many tests fail and t1013-read-tree-submodule.sh #52 is one
of them.

Thanks.

not ok 52 - git_test_func: modified submodule does not update submodule work tree to invalid commit
#
#                       prolog &&
#                       reset_work_tree_to add_sub1 &&
#                       (
#                               cd submodule_update &&
#                               git branch -t invalid_sub1 origin/invalid_sub1 &&
#                               $command invalid_sub1 &&
#                               test_superproject_content origin/invalid_sub1 &&
#                               test_submodule_content sub1 origin/add_sub1 &&
#                               test_must_fail git submodule update &&
#                               test_submodule_content sub1 origin/add_sub1
#                       )
#
1..52

=================================================================
==git==1541109==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 768 byte(s) in 1 object(s) allocated from:
    #0 0x561ea1a821c7 in realloc (git+0x8a1c7) (BuildId: 8e698d3663135d471ee5cb682ce22cd9ec7b4322)
    #1 0x561ea1da4126 in xrealloc wrapper.c:140:8
    #2 0x561ea1d181a8 in refspec_append refspec.c:209:2
    #3 0x561ea1d1e698 in handle_config remote.c:506:3
    #4 0x561ea1bf7878 in configset_iter config.c:2140:7
    #5 0x561ea1bf775a in repo_config config.c:2519:2
    #6 0x561ea1d195fd in read_config remote.c:615:2
    #7 0x561ea1d1b6ba in repo_remote_from_url remote.c:1794:2
    #8 0x561ea1b8ae07 in repo_get_default_remote builtin/submodule--helper.c:54:29
    #9 0x561ea1b8d475 in get_default_remote_submodule builtin/submodule--helper.c:135:8
    #10 0x561ea1b8d789 in fetch_in_submodule builtin/submodule--helper.c:2355:10
    #11 0x561ea1b8d98e in run_update_procedure builtin/submodule--helper.c:2481:7
    #12 0x561ea1b8c7b8 in update_submodule builtin/submodule--helper.c:2700:9
    #13 0x561ea1b8ba35 in update_submodules builtin/submodule--helper.c:2784:10
    #14 0x561ea1b87097 in module_update builtin/submodule--helper.c:2924:8
    #15 0x561ea1b84b9d in cmd_submodule__helper builtin/submodule--helper.c:3646:9
    #16 0x561ea1a86cfb in run_builtin git.c:480:11
    #17 0x561ea1a858a0 in handle_builtin git.c:746:9
    #18 0x561ea1a866a8 in run_argv git.c:813:4
    #19 0x561ea1a8562b in cmd_main git.c:953:19
    #20 0x561ea1ba41da in main common-main.c:9:11
    #21 0x7f60975e6ca7 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #22 0x7f60975e6d64 in __libc_start_main csu/../csu/libc-start.c:360:3
    #23 0x561ea1a52210 in _start (git+0x5a210) (BuildId: 8e698d3663135d471ee5cb682ce22cd9ec7b4322)

DEDUP_TOKEN: __interceptor_realloc--xrealloc--refspec_append--handle_config--configset_iter--repo_config--read_config--repo_remote_from_url--repo_get_default_remote--get_default_remote_submodule--fetch_in_submodule--run_update_procedure--update_submodule--update_submodules--module_update--cmd_submodule__helper--run_builtin--handle_builtin--run_argv--cmd_main--main--__libc_start_call_main--__libc_start_main--_start
Direct leak of 192 byte(s) in 1 object(s) allocated from:
    #0 0x561ea1a821c7 in realloc (git+0x8a1c7) (BuildId: 8e698d3663135d471ee5cb682ce22cd9ec7b4322)
    #1 0x561ea1da4126 in xrealloc wrapper.c:140:8
    #2 0x561ea1d1edb4 in add_merge remote.c:177:2
    #3 0x561ea1d1e23c in handle_config remote.c:432:4
    #4 0x561ea1bf7878 in configset_iter config.c:2140:7
    #5 0x561ea1bf775a in repo_config config.c:2519:2
    #6 0x561ea1d195fd in read_config remote.c:615:2
    #7 0x561ea1d1b6ba in repo_remote_from_url remote.c:1794:2
    #8 0x561ea1b8ae07 in repo_get_default_remote builtin/submodule--helper.c:54:29
    #9 0x561ea1b8d475 in get_default_remote_submodule builtin/submodule--helper.c:135:8
    #10 0x561ea1b8d789 in fetch_in_submodule builtin/submodule--helper.c:2355:10
    #11 0x561ea1b8d98e in run_update_procedure builtin/submodule--helper.c:2481:7
    #12 0x561ea1b8c7b8 in update_submodule builtin/submodule--helper.c:2700:9
    #13 0x561ea1b8ba35 in update_submodules builtin/submodule--helper.c:2784:10
    #14 0x561ea1b87097 in module_update builtin/submodule--helper.c:2924:8
    #15 0x561ea1b84b9d in cmd_submodule__helper builtin/submodule--helper.c:3646:9
    #16 0x561ea1a86cfb in run_builtin git.c:480:11
    #17 0x561ea1a858a0 in handle_builtin git.c:746:9
    #18 0x561ea1a866a8 in run_argv git.c:813:4
    #19 0x561ea1a8562b in cmd_main git.c:953:19
    #20 0x561ea1ba41da in main common-main.c:9:11
    #21 0x7f60975e6ca7 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #22 0x7f60975e6d64 in __libc_start_main csu/../csu/libc-start.c:360:3
    #23 0x561ea1a52210 in _start (git+0x5a210) (BuildId: 8e698d3663135d471ee5cb682ce22cd9ec7b4322)

DEDUP_TOKEN: __interceptor_realloc--xrealloc--add_merge--handle_config--configset_iter--repo_config--read_config--repo_remote_from_url--repo_get_default_remote--get_default_remote_submodule--fetch_in_submodule--run_update_procedure--update_submodule--update_submodules--module_update--cmd_submodule__helper--run_builtin--handle_builtin--run_argv--cmd_main--main--__libc_start_call_main--__libc_start_main--_start
Indirect leak of 36 byte(s) in 1 object(s) allocated from:
    #0 0x561ea1a81d3d in malloc (git+0x89d3d) (BuildId: 8e698d3663135d471ee5cb682ce22cd9ec7b4322)
    #1 0x7f60976667a9 in strdup string/strdup.c:42:15
    #2 0x561ea1da3e14 in xstrdup wrapper.c:43:14
    #3 0x561ea1d17f2b in refspec_item_init refspec.c:160:14
    #4 0x561ea1d17ef1 in refspec_item_init_fetch refspec.c:166:9
    #5 0x561ea1d180dd in refspec_append refspec.c:203:9
    #6 0x561ea1d1e698 in handle_config remote.c:506:3
    #7 0x561ea1bf7878 in configset_iter config.c:2140:7
    #8 0x561ea1bf775a in repo_config config.c:2519:2
    #9 0x561ea1d195fd in read_config remote.c:615:2
    #10 0x561ea1d1b6ba in repo_remote_from_url remote.c:1794:2
    #11 0x561ea1b8ae07 in repo_get_default_remote builtin/submodule--helper.c:54:29
    #12 0x561ea1b8d475 in get_default_remote_submodule builtin/submodule--helper.c:135:8
    #13 0x561ea1b8d789 in fetch_in_submodule builtin/submodule--helper.c:2355:10
    #14 0x561ea1b8d98e in run_update_procedure builtin/submodule--helper.c:2481:7
    #15 0x561ea1b8c7b8 in update_submodule builtin/submodule--helper.c:2700:9
    #16 0x561ea1b8ba35 in update_submodules builtin/submodule--helper.c:2784:10
    #17 0x561ea1b87097 in module_update builtin/submodule--helper.c:2924:8
    #18 0x561ea1b84b9d in cmd_submodule__helper builtin/submodule--helper.c:3646:9
    #19 0x561ea1a86cfb in run_builtin git.c:480:11
    #20 0x561ea1a858a0 in handle_builtin git.c:746:9
    #21 0x561ea1a866a8 in run_argv git.c:813:4
    #22 0x561ea1a8562b in cmd_main git.c:953:19
    #23 0x561ea1ba41da in main common-main.c:9:11
    #24 0x7f60975e6ca7 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #25 0x7f60975e6d64 in __libc_start_main csu/../csu/libc-start.c:360:3
    #26 0x561ea1a52210 in _start (git+0x5a210) (BuildId: 8e698d3663135d471ee5cb682ce22cd9ec7b4322)

DEDUP_TOKEN: __interceptor_malloc--strdup--xstrdup--refspec_item_init--refspec_item_init_fetch--refspec_append--handle_config--configset_iter--repo_config--read_config--repo_remote_from_url--repo_get_default_remote--get_default_remote_submodule--fetch_in_submodule--run_update_procedure--update_submodule--update_submodules--module_update--cmd_submodule__helper--run_builtin--handle_builtin--run_argv--cmd_main--main--__libc_start_call_main--__libc_start_main--_start
Indirect leak of 22 byte(s) in 1 object(s) allocated from:
    #0 0x561ea1a81d3d in malloc (git+0x89d3d) (BuildId: 8e698d3663135d471ee5cb682ce22cd9ec7b4322)
    #1 0x561ea1da3e92 in do_xmalloc wrapper.c:55:8
    #2 0x561ea1da3f94 in do_xmallocz wrapper.c:89:8
    #3 0x561ea1da3f26 in xmallocz wrapper.c:97:9
    #4 0x561ea1da3ff8 in xmemdupz wrapper.c:113:16
    #5 0x561ea1da4077 in xstrndup wrapper.c:119:9
    #6 0x561ea1d19118 in parse_refspec refspec.c:55:15
    #7 0x561ea1d17f46 in refspec_item_init refspec.c:161:9
    #8 0x561ea1d17ef1 in refspec_item_init_fetch refspec.c:166:9
    #9 0x561ea1d180dd in refspec_append refspec.c:203:9
    #10 0x561ea1d1e698 in handle_config remote.c:506:3
    #11 0x561ea1bf7878 in configset_iter config.c:2140:7
    #12 0x561ea1bf775a in repo_config config.c:2519:2
    #13 0x561ea1d195fd in read_config remote.c:615:2
    #14 0x561ea1d1b6ba in repo_remote_from_url remote.c:1794:2
    #15 0x561ea1b8ae07 in repo_get_default_remote builtin/submodule--helper.c:54:29
    #16 0x561ea1b8d475 in get_default_remote_submodule builtin/submodule--helper.c:135:8
    #17 0x561ea1b8d789 in fetch_in_submodule builtin/submodule--helper.c:2355:10
    #18 0x561ea1b8d98e in run_update_procedure builtin/submodule--helper.c:2481:7
    #19 0x561ea1b8c7b8 in update_submodule builtin/submodule--helper.c:2700:9
    #20 0x561ea1b8ba35 in update_submodules builtin/submodule--helper.c:2784:10
    #21 0x561ea1b87097 in module_update builtin/submodule--helper.c:2924:8
    #22 0x561ea1b84b9d in cmd_submodule__helper builtin/submodule--helper.c:3646:9
    #23 0x561ea1a86cfb in run_builtin git.c:480:11
    #24 0x561ea1a858a0 in handle_builtin git.c:746:9
    #25 0x561ea1a866a8 in run_argv git.c:813:4
    #26 0x561ea1a8562b in cmd_main git.c:953:19
    #27 0x561ea1ba41da in main common-main.c:9:11

DEDUP_TOKEN: __interceptor_malloc--do_xmalloc--do_xmallocz--xmallocz--xmemdupz--xstrndup--parse_refspec--refspec_item_init--refspec_item_init_fetch--refspec_append--handle_config--configset_iter--repo_config--read_config--repo_remote_from_url--repo_get_default_remote--get_default_remote_submodule--fetch_in_submodule--run_update_procedure--update_submodule--update_submodules--module_update--cmd_submodule__helper--run_builtin--handle_builtin--run_argv--cmd_main--main
Indirect leak of 18 byte(s) in 1 object(s) allocated from:
    #0 0x561ea1a81d3d in malloc (git+0x89d3d) (BuildId: 8e698d3663135d471ee5cb682ce22cd9ec7b4322)
    #1 0x7f60976667a9 in strdup string/strdup.c:42:15
    #2 0x561ea1da3e14 in xstrdup wrapper.c:43:14
    #3 0x561ea1d1e22d in handle_config remote.c:432:22
    #4 0x561ea1bf7878 in configset_iter config.c:2140:7
    #5 0x561ea1bf775a in repo_config config.c:2519:2
    #6 0x561ea1d195fd in read_config remote.c:615:2
    #7 0x561ea1d1b6ba in repo_remote_from_url remote.c:1794:2
    #8 0x561ea1b8ae07 in repo_get_default_remote builtin/submodule--helper.c:54:29
    #9 0x561ea1b8d475 in get_default_remote_submodule builtin/submodule--helper.c:135:8
    #10 0x561ea1b8d789 in fetch_in_submodule builtin/submodule--helper.c:2355:10
    #11 0x561ea1b8d98e in run_update_procedure builtin/submodule--helper.c:2481:7
    #12 0x561ea1b8c7b8 in update_submodule builtin/submodule--helper.c:2700:9
    #13 0x561ea1b8ba35 in update_submodules builtin/submodule--helper.c:2784:10
    #14 0x561ea1b87097 in module_update builtin/submodule--helper.c:2924:8
    #15 0x561ea1b84b9d in cmd_submodule__helper builtin/submodule--helper.c:3646:9
    #16 0x561ea1a86cfb in run_builtin git.c:480:11
    #17 0x561ea1a858a0 in handle_builtin git.c:746:9
    #18 0x561ea1a866a8 in run_argv git.c:813:4
    #19 0x561ea1a8562b in cmd_main git.c:953:19
    #20 0x561ea1ba41da in main common-main.c:9:11
    #21 0x7f60975e6ca7 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #22 0x7f60975e6d64 in __libc_start_main csu/../csu/libc-start.c:360:3
    #23 0x561ea1a52210 in _start (git+0x5a210) (BuildId: 8e698d3663135d471ee5cb682ce22cd9ec7b4322)

DEDUP_TOKEN: __interceptor_malloc--strdup--xstrdup--handle_config--configset_iter--repo_config--read_config--repo_remote_from_url--repo_get_default_remote--get_default_remote_submodule--fetch_in_submodule--run_update_procedure--update_submodule--update_submodules--module_update--cmd_submodule__helper--run_builtin--handle_builtin--run_argv--cmd_main--main--__libc_start_call_main--__libc_start_main--_start
Indirect leak of 13 byte(s) in 1 object(s) allocated from:
    #0 0x561ea1a81d3d in malloc (git+0x89d3d) (BuildId: 8e698d3663135d471ee5cb682ce22cd9ec7b4322)
    #1 0x561ea1da3e92 in do_xmalloc wrapper.c:55:8
    #2 0x561ea1da3f94 in do_xmallocz wrapper.c:89:8
    #3 0x561ea1da3f26 in xmallocz wrapper.c:97:9
    #4 0x561ea1da3ff8 in xmemdupz wrapper.c:113:16
    #5 0x561ea1da4077 in xstrndup wrapper.c:119:9
    #6 0x561ea1d1923b in parse_refspec refspec.c:73:15
    #7 0x561ea1d17f46 in refspec_item_init refspec.c:161:9
    #8 0x561ea1d17ef1 in refspec_item_init_fetch refspec.c:166:9
    #9 0x561ea1d180dd in refspec_append refspec.c:203:9
    #10 0x561ea1d1e698 in handle_config remote.c:506:3
    #11 0x561ea1bf7878 in configset_iter config.c:2140:7
    #12 0x561ea1bf775a in repo_config config.c:2519:2
    #13 0x561ea1d195fd in read_config remote.c:615:2
    #14 0x561ea1d1b6ba in repo_remote_from_url remote.c:1794:2
    #15 0x561ea1b8ae07 in repo_get_default_remote builtin/submodule--helper.c:54:29
    #16 0x561ea1b8d475 in get_default_remote_submodule builtin/submodule--helper.c:135:8
    #17 0x561ea1b8d789 in fetch_in_submodule builtin/submodule--helper.c:2355:10
    #18 0x561ea1b8d98e in run_update_procedure builtin/submodule--helper.c:2481:7
    #19 0x561ea1b8c7b8 in update_submodule builtin/submodule--helper.c:2700:9
    #20 0x561ea1b8ba35 in update_submodules builtin/submodule--helper.c:2784:10
    #21 0x561ea1b87097 in module_update builtin/submodule--helper.c:2924:8
    #22 0x561ea1b84b9d in cmd_submodule__helper builtin/submodule--helper.c:3646:9
    #23 0x561ea1a86cfb in run_builtin git.c:480:11
    #24 0x561ea1a858a0 in handle_builtin git.c:746:9
    #25 0x561ea1a866a8 in run_argv git.c:813:4
    #26 0x561ea1a8562b in cmd_main git.c:953:19
    #27 0x561ea1ba41da in main common-main.c:9:11

DEDUP_TOKEN: __interceptor_malloc--do_xmalloc--do_xmallocz--xmallocz--xmemdupz--xstrndup--parse_refspec--refspec_item_init--refspec_item_init_fetch--refspec_append--handle_config--configset_iter--repo_config--read_config--repo_remote_from_url--repo_get_default_remote--get_default_remote_submodule--fetch_in_submodule--run_update_procedure--update_submodule--update_submodules--module_update--cmd_submodule__helper--run_builtin--handle_builtin--run_argv--cmd_main--main
SUMMARY: LeakSanitizer: 1049 byte(s) leaked in 6 allocation(s).
Our logs revealed a memory leak...




  reply	other threads:[~2025-06-17 15:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11  0:52 [PATCH 0/6] submodule: improve remote lookup logic Jacob Keller
2025-06-11  0:52 ` [PATCH 1/6] dir: move starts_with_dot(_dot)_slash to dir.h Jacob Keller
2025-06-11  0:52 ` [PATCH 2/6] remote: remove the_repository from some functions Jacob Keller
2025-06-11  0:52 ` [PATCH 3/6] remote: check branch->merge before access in branch_release Jacob Keller
2025-06-11  0:52 ` [PATCH 4/6] submodule--helper: improve logic for fallback remote name Jacob Keller
2025-06-17  2:58   ` Lidong Yan
2025-06-17 17:53     ` Jacob Keller
2025-06-17 18:57     ` Jacob Keller
2025-06-17 13:30   ` Junio C Hamano
2025-06-11  0:52 ` [PATCH 5/6] submodule: move get_default_remote_submodule() Jacob Keller
2025-06-11  0:52 ` [PATCH 6/6] submodule: look up remotes by URL first Jacob Keller
2025-06-16 22:27 ` [PATCH 0/6] submodule: improve remote lookup logic Jacob Keller
2025-06-16 22:41   ` Junio C Hamano
2025-06-16 23:20     ` Jacob Keller
2025-06-17 15:09       ` Junio C Hamano [this message]
2025-06-17 16:16         ` Junio C Hamano
2025-06-17 21:28         ` Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4iwexv4n.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jacob.keller@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.