All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "D. Ben Knoble via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
	 Philippe Blain <levraiphilippeblain@gmail.com>,
	"D. Ben Knoble" <ben.knoble+github@gmail.com>
Subject: Re: [PATCH v3] completion: repair config completion for Zsh
Date: Mon, 06 Jan 2025 17:23:55 -0800	[thread overview]
Message-ID: <xmqq4j2bwh5g.fsf@gitster.g> (raw)
In-Reply-To: <pull.1860.v3.git.git.1736200026899.gitgitgadget@gmail.com> (D. Ben Knoble via GitGitGadget's message of "Mon, 06 Jan 2025 21:47:06 +0000")

"D. Ben Knoble via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: "D. Ben Knoble" <ben.knoble+github@gmail.com>
>
> Commit 1e0ee4087e (completion: add and use
> __git_compute_first_level_config_vars_for_section, 2024-02-10) uses an
> indirect variable syntax that is only valid for Bash, but the Zsh
> completion code relies on the Bash completion code to function. Zsh
> ...
> Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>
> Acked-by: Philippe Blain <levraiphilippeblain@gmail.com>

Thanks, both.  Will queue.


      reply	other threads:[~2025-01-07  1:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-30  0:00 [PATCH] completion: repair config completion for Zsh D. Ben Knoble via GitGitGadget
2025-01-03 17:20 ` Philippe Blain
2025-01-03 18:07   ` D. Ben Knoble
2025-01-04 14:47 ` [PATCH v2] " D. Ben Knoble via GitGitGadget
2025-01-06 21:47   ` [PATCH v3] " D. Ben Knoble via GitGitGadget
2025-01-07  1:23     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4j2bwh5g.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ben.knoble+github@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=levraiphilippeblain@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.