All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org,  Daniel Engberg <daniel.engberg.lists@pyret.net>
Subject: Re: [PATCH] meson: skip gitweb build when Perl is disabled
Date: Fri, 20 Dec 2024 07:50:40 -0800	[thread overview]
Message-ID: <xmqq4j2yfj5b.fsf@gitster.g> (raw)
In-Reply-To: <Z2WKnAh2BVWr063E@pks.im> (Patrick Steinhardt's message of "Fri, 20 Dec 2024 16:18:01 +0100")

Patrick Steinhardt <ps@pks.im> writes:

> I don't think it's incorrect. The Perl features are those that the Git
> distribution itself uses, including all the Perl modules in "perl/". The
> gitweb subsystem, as far as I can see, uses none of those functions and
> thus the data we configure in case `perl_features_enabled` is true is
> irrelevant for gitweb.

Ah, now that makes sense to me why these things are laid out that
way.  Thanks.

  reply	other threads:[~2024-12-20 15:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-20  7:26 [PATCH] meson: skip gitweb build when Perl is disabled Patrick Steinhardt
2024-12-20 15:03 ` Junio C Hamano
2024-12-20 15:18   ` Patrick Steinhardt
2024-12-20 15:50     ` Junio C Hamano [this message]
2024-12-20 16:30 ` [PATCH v2] " Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4j2yfj5b.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=daniel.engberg.lists@pyret.net \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.