From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>, Patrick Steinhardt <ps@pks.im>,
Phillip Wood <phillip.wood@dunelm.org.uk>,
Eric Sunshine <sunshine@sunshineco.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH v2 3/1] t-strvec: tighten .alloc check in check_strvec
Date: Mon, 15 Jul 2024 10:27:16 -0700 [thread overview]
Message-ID: <xmqq4j8q4lcb.fsf@gitster.g> (raw)
In-Reply-To: <bf7fd471-18fb-41df-a306-2413c9d441bd@web.de> ("René Scharfe"'s message of "Mon, 15 Jul 2024 18:47:49 +0200")
René Scharfe <l.s.r@web.de> writes:
>>> check_uint((vec)->nr, ==, ARRAY_SIZE(expect) - 1) && \
>>> - check_uint((vec)->nr, <=, (vec)->alloc)) { \
>>> + ((vec)->v == empty_strvec ? \
>>> + check_uint((vec)->nr, ==, (vec)->alloc) : \
>>> + check_uint((vec)->nr, <, (vec)->alloc))) { \
>>
>> Not a huge deal but with empty_strvec, don't we want to barf if
>> nr==alloc==1?
>
> Yes, and that's handled by the comparison with ARRAY_SIZE(expect) - 1
> above.
Ah, OK, thanks.
next prev parent reply other threads:[~2024-07-15 17:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 18:04 [PATCH] t-strvec: use test_msg() René Scharfe
2024-07-04 18:31 ` Eric Sunshine
2024-07-05 9:44 ` Phillip Wood
2024-07-05 17:03 ` [PATCH v2] " René Scharfe
2024-07-09 11:32 ` Jeff King
2024-07-14 10:17 ` René Scharfe
2024-07-16 1:43 ` Jeff King
2024-07-16 16:43 ` René Scharfe
2024-07-14 17:06 ` [PATCH v2 2/1] t-strvec: improve check_strvec() output René Scharfe
2024-07-15 14:44 ` Junio C Hamano
2024-07-14 17:06 ` [PATCH v2 3/1] t-strvec: tighten .alloc check in check_strvec René Scharfe
2024-07-15 14:43 ` Junio C Hamano
2024-07-15 16:47 ` René Scharfe
2024-07-15 17:27 ` Junio C Hamano [this message]
2024-07-14 10:17 ` [PATCH v3] t-strvec: improve check_strvec() output René Scharfe
2024-07-14 17:06 ` René Scharfe
2024-07-16 4:37 ` Jeff King
2024-07-16 15:20 ` Junio C Hamano
2024-07-16 16:14 ` [PATCH] t-strvec: fix type mismatch in check_strvec René Scharfe
2024-07-16 16:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4j8q4lcb.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.