From: Junio C Hamano <gitster@pobox.com>
To: Sean Allred <allred.sean@gmail.com>
Cc: David <dark0dave@mykolab.com>, git@vger.kernel.org
Subject: Re: [PATCH] submodule: allow gitsubmodules to be pointed at tags
Date: Mon, 24 Jun 2024 09:40:18 -0700 [thread overview]
Message-ID: <xmqq4j9icn0t.fsf@gitster.g> (raw)
In-Reply-To: <m0sex2pi7q.fsf@epic96565.epic.com> (Sean Allred's message of "Mon, 24 Jun 2024 08:45:45 -0500")
Sean Allred <allred.sean@gmail.com> writes:
> If you're ok with that behavior, then does it make sense to
> generalize it to the concept of a ref instead of just a tag name?
> This may do a better job of communicating the idea that no ref is
> inherently immovable.
Yup, I only took a brief glance at the patch, and I didn't quite see
the point of duplicationg an almost parallel mechanism to an
existing (--single-branch, set-branch) pair of the feature, only to
replace "branch" with "tag" (the patch noise / code churn did not
seem worth it).
In other words, is there a situation where a branch cannot be used
(or using a branch is more cumbersome or awkward) when the user
wants to use a tag with this patch? As users can just as easily
move tags as they can move branches, the verb "freeze" used in the
proposed log message probably does not reflect reality anyway, as
you already pointed out.
Thanks.
prev parent reply other threads:[~2024-06-24 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 12:01 [PATCH] submodule: allow gitsubmodules to be pointed at tags dark0dave via GitGitGadget
2024-06-24 13:26 ` Sean Allred
[not found] ` <7D5BFC58-9BF1-4818-828D-453C416949EB@mykolab.com>
2024-06-24 13:45 ` Sean Allred
2024-06-24 16:40 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4j9icn0t.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=allred.sean@gmail.com \
--cc=dark0dave@mykolab.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.