From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: "Sören Krecker" <soekkle@freenet.de>,
sunshine@sunshineco.com, git@vger.kernel.org
Subject: Re: [PATCH v7 1/1] mingw: give more details about unsafe directory's ownership
Date: Tue, 09 Jan 2024 14:34:38 -0800 [thread overview]
Message-ID: <xmqq4jfmf85d.fsf@gitster.g> (raw)
In-Reply-To: <e7594386-4a26-467d-bd27-8ac6268ad219@kdbg.org> (Johannes Sixt's message of "Tue, 9 Jan 2024 22:05:39 +0100")
Johannes Sixt <j6t@kdbg.org> writes:
>> Because len_domain includes the terminating NUL for the domain part,
>> (*str)[len_domain-1] is that NUL, no? And that is what you want to
>> overwrite to make the two strings <d> <NUL> <u> <NUL> into a single
>> one <d> <slash> <u> <NUL>. So...
>
> But after a successful call, len_domain and len_user have been modified
> to contain the lengths of the names (not counting the NULs), ...
Ah, that is what I missed. Thanks.
next prev parent reply other threads:[~2024-01-09 22:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 12:03 [PATCH 0/1 v2] Replace SID with domain/username on Windows Sören Krecker
2023-12-29 12:03 ` [PATCH v2 1/1] Replace SID with domain/username Sören Krecker
2024-01-02 16:20 ` Junio C Hamano
2024-01-02 17:33 ` Junio C Hamano
2023-12-31 4:08 ` [PATCH 0/1 v2] Replace SID with domain/username on Windows Eric Sunshine
2023-12-31 9:12 ` [PATCH V3 0/1] " Sören Krecker
2023-12-31 9:12 ` [PATCH v3 1/1] Replace SID with domain/username Sören Krecker
2024-01-02 17:43 ` Junio C Hamano
2024-01-02 19:15 ` [PATCH V4 0/1] Replace SID with domain/username on Windows Sören Krecker
2024-01-02 19:15 ` [PATCH V4 1/1] Replace SID with domain/username Sören Krecker
2024-01-03 0:43 ` Junio C Hamano
2024-01-03 8:21 ` Matthias Aßhauer
2024-01-03 22:22 ` Junio C Hamano
2024-01-04 19:22 ` [PATCH v5 0/1] Replace SID with domain/username on Windows Sören Krecker
2024-01-04 19:22 ` [PATCH v5 1/1] Adds domain/username to error message Sören Krecker
2024-01-04 20:09 ` Junio C Hamano
2024-01-06 11:29 ` [PATCH v6 0/1] mingw: give more details about unsafe directory's ownership Sören Krecker
2024-01-06 11:29 ` [PATCH v6 1/1] " Sören Krecker
2024-01-07 20:02 ` Johannes Sixt
2024-01-08 17:38 ` [PATCH v6 0/1] mingw: give more details about unsafe directory's Sören Krecker
2024-01-08 17:38 ` [PATCH v7 1/1] mingw: give more details about unsafe directory's ownership Sören Krecker
2024-01-08 19:18 ` Junio C Hamano
2024-01-09 19:27 ` Johannes Sixt
2024-01-09 20:06 ` Junio C Hamano
2024-01-09 21:05 ` Johannes Sixt
2024-01-09 22:34 ` Junio C Hamano [this message]
2024-01-08 17:51 ` [PATCH v6 0/1] mingw: give more details about unsafe directory's Dragan Simic
2023-12-31 9:18 ` [PATCH V3 0/1] Replace SID with domain/username on Windows Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4jfmf85d.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=soekkle@freenet.de \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.