From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: "Alejandro R Sedeño" <asedeno@google.com>,
asedeno@mit.edu, git@vger.kernel.org, sunshine@sunshineco.com
Subject: Re: [PATCH] statinfo.h: move DTYPE defines from dir.h
Date: Sat, 03 Jun 2023 11:30:44 +0900 [thread overview]
Message-ID: <xmqq4jnp6zvv.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BHZ6a8VEuK=miMAcBG9RbUz+epuQ+d1xvwbRj_tsnYqcQ@mail.gmail.com> (Elijah Newren's message of "Fri, 2 Jun 2023 19:04:31 -0700")
Elijah Newren <newren@gmail.com> writes:
> There are two _different_ things named "struct dir_entry" in the codebase:
In the longer term, we should rename such a local type to avoid name
clashes with the global one. But I of course am OK to leave it
outside the topic to clean it up.
In any case, it is worth saying in the proposed log message why
name-hash cannot use cache.h if we make it include dir.h; it is easy
to do so (i.e. "it has its own 'dir_entry' that is used for other
purpose").
Thanks.
next prev parent reply other threads:[~2023-06-03 2:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 18:45 [PATCH] statinfo.h: move DTYPE defines from dir.h Aleajndro R Sedeño
2023-06-02 18:50 ` Alejandro Sedeño
2023-06-02 19:06 ` Eric Sunshine
2023-06-02 19:21 ` Alejandro Sedeño
2023-06-02 19:27 ` Alejandro R Sedeño
2023-06-03 1:47 ` Elijah Newren
2023-06-03 1:56 ` Junio C Hamano
2023-06-03 2:04 ` Elijah Newren
2023-06-03 2:30 ` Junio C Hamano [this message]
2023-06-03 3:02 ` Alejandro Sedeño
2023-06-06 20:59 ` Alejandro R Sedeño
2023-06-12 18:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4jnp6zvv.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=asedeno@google.com \
--cc=asedeno@mit.edu \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.