From: Junio C Hamano <gitster@pobox.com>
To: "Kyle Zhao via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Derrick Stolee" <derrickstolee@github.com>,
"Taylor Blau" <me@ttaylorr.com>, kylezhao <kylezhao@tencent.com>,
"Jeff King" <peff@peff.net>
Subject: Re: [PATCH v4] send-pack.c: add config push.useBitmaps
Date: Fri, 17 Jun 2022 14:32:04 -0700 [thread overview]
Message-ID: <xmqq4k0jnfhn.fsf@gitster.g> (raw)
In-Reply-To: <pull.1263.v4.git.1655492779228.gitgitgadget@gmail.com> (Kyle Zhao via GitGitGadget's message of "Fri, 17 Jun 2022 19:06:19 +0000")
"Kyle Zhao via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Changes since v3:
>
> * changed the commit message
> * s/no_use_bitmaps/disable_bitmaps in send-pack.h and send-pack.c
> * I modified the document about "push.useBitmaps". When it is true, Git
> will keep the historical behaviour. So I mainly introduced what
> happens when it set to false.
> * use test_config and test_unconfig for test.
Looking good. Will queue.
Thanks.
prev parent reply other threads:[~2022-06-17 21:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 11:08 [PATCH] send-pack.c: add config push.useBitmaps Kyle Zhao via GitGitGadget
2022-06-15 13:09 ` Derrick Stolee
2022-06-15 21:24 ` Taylor Blau
2022-06-15 19:47 ` Ævar Arnfjörð Bjarmason
2022-06-15 21:32 ` Taylor Blau
2022-06-16 2:13 ` [Internet]Re: " kylezhao(赵柯宇)
2022-06-16 3:36 ` [PATCH v2] " Kyle Zhao via GitGitGadget
2022-06-16 13:02 ` Derrick Stolee
2022-06-16 13:38 ` Ævar Arnfjörð Bjarmason
2022-06-16 15:11 ` [Internet]Re: " kylezhao(赵柯宇)
2022-06-16 21:17 ` Taylor Blau
2022-06-16 18:12 ` Junio C Hamano
2022-06-16 21:04 ` Jeff King
2022-06-17 3:59 ` [PATCH v3] " Kyle Zhao via GitGitGadget
2022-06-17 17:01 ` Junio C Hamano
2022-06-17 19:06 ` [PATCH v4] " Kyle Zhao via GitGitGadget
2022-06-17 21:32 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4k0jnfhn.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=kylezhao@tencent.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.