All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Carlo Arenas <carenas@gmail.com>
Cc: git@vger.kernel.org, tr@thomasrast.ch
Subject: Re: [PATCH] add -p: avoid use of undefined $key when ReadKey -> EOF
Date: Sun, 28 Nov 2021 15:15:48 -0800	[thread overview]
Message-ID: <xmqq4k7v6fdn.fsf@gitster.g> (raw)
In-Reply-To: <CAPUEspjo+cKLnE+MoABp_NnGDCCz8fL=pJj3ZNsKmCVetUn1jA@mail.gmail.com> (Carlo Arenas's message of "Sun, 28 Nov 2021 12:52:39 -0800")

Carlo Arenas <carenas@gmail.com> writes:

> I have no strong opinions eitherway, so let me know what you would
> prefer and will get a v2 with it; thanks for reviewing.

I have no strong preference either way, so I just queued what we
reviewed as-is.

Thanks for the fix.

      reply	other threads:[~2021-11-28 23:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-28 17:49 [PATCH] add -p: avoid use of undefined $key when ReadKey -> EOF Carlo Marcelo Arenas Belón
2021-11-28 19:44 ` Junio C Hamano
2021-11-28 20:52   ` Carlo Arenas
2021-11-28 23:15     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4k7v6fdn.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=tr@thomasrast.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.