All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Orgad Shaneh <orgads@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] name-rev: Fix tag lookup on repository with mixed types of tags
Date: Thu, 22 Jun 2017 15:03:46 -0700	[thread overview]
Message-ID: <xmqq4lv7issd.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGHpTBLXrrt0DykbCQHqp2up_BqOVftc8_8Towi3sDbh3M12LQ@mail.gmail.com> (Orgad Shaneh's message of "Thu, 22 Jun 2017 22:42:16 +0300")

Orgad Shaneh <orgads@gmail.com> writes:

> Commit 7550424804 (name-rev: include taggerdate in considering the best
> name) introduced a bug in name-rev.
>
> If a repository has both annotated and non-annotated tags, annotated
> tag will always win, even if it was created decades after the commit.

Thanks.  It is a problem that light-weight tags are unduly
penalized, and we attempted to address it a few months ago in a
slightly different way.  The necessary changes are already in
'master' but not yet in any released branch.

Here is an entry in the Release Notes for the next release that will
come out of the current 'master'.

 * "git describe --contains" penalized light-weight tags so much that
   they were almost never considered.  Instead, give them about the
   same chance to be considered as an annotated tag that is the same
   age as the underlying commit would.
   (merge ef1e74065c jc/name-rev-lw-tag later to maint).


  reply	other threads:[~2017-06-22 22:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-22 19:42 [PATCH] name-rev: Fix tag lookup on repository with mixed types of tags Orgad Shaneh
2017-06-22 22:03 ` Junio C Hamano [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-06-22 19:52 orgads
2017-06-22 20:38 ` Stefan Beller
2017-10-18 13:24 orgads
2017-10-19  1:54 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4lv7issd.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=orgads@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.