From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/3] transport: allow summary-width to be computed dynamically
Date: Sat, 22 Oct 2016 09:25:27 -0700 [thread overview]
Message-ID: <xmqq4m449wqw.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161022050426.t2fifjqrldc6mebc@sigill.intra.peff.net> (Jeff King's message of "Sat, 22 Oct 2016 01:04:26 -0400")
Jeff King <peff@peff.net> writes:
> On Fri, Oct 21, 2016 at 09:39:45PM -0700, Junio C Hamano wrote:
>
>> And this is the final one.
>>
>> -- >8 --
>> From: Junio C Hamano <gitster@pobox.com>
>> Date: Fri, 21 Oct 2016 21:33:06 -0700
>> Subject: [PATCH] transport: compute summary-width dynamically
>>
>> Now all that is left to do is to actually iterate over the refs
>> and measure the display width needed to show their abbreviation.
>
> I think we crossed emails. :) This is obviously correct, if we don't
> mind paying the find_unique_abbrev cost twice for each sha1.
Indeed we did. I do not think the cost matters that much in the
codepath to produce the final summary output.
> This is a minor style nit, but I think it's better to avoid mixing
> unrelated bits between the initialization, condition, and iteration bits
> of a for loop.
Yeah, you're right.
prev parent reply other threads:[~2016-10-22 16:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 0:26 [BUG] fetch output is ugly in 'next' Jeff King
2016-10-21 12:11 ` Duy Nguyen
2016-10-21 13:07 ` Duy Nguyen
2016-10-21 16:50 ` Junio C Hamano
2016-10-21 21:42 ` Jeff King
2016-10-21 22:14 ` Junio C Hamano
2016-10-21 22:39 ` [PATCH 0/3] " Junio C Hamano
2016-10-21 22:39 ` [PATCH 1/3] transport: pass summary_width down the callchain Junio C Hamano
2016-10-21 22:39 ` [PATCH 2/3] fetch: " Junio C Hamano
2016-10-21 22:39 ` [PATCH 3/3] transport: allow summary-width to be computed dynamically Junio C Hamano
2016-10-22 4:10 ` Jeff King
2016-10-22 4:39 ` Junio C Hamano
2016-10-22 5:04 ` Jeff King
2016-10-22 16:25 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4m449wqw.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.