All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Mehul Jain <mehul.jain2029@gmail.com>
Cc: Jeff King <peff@peff.net>, Git Mailing List <git@vger.kernel.org>,
	Austin English <austinenglish@gmail.com>
Subject: Re: [RFC/PATCH 2/2] log: add "--no-show-signature" command line option
Date: Fri, 27 May 2016 10:37:16 -0700	[thread overview]
Message-ID: <xmqq4m9js8qb.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CA+DCAeTnkTRnmscduio1-buKd2gNcaScYkLY7YfEQ+_Cm=Z28Q@mail.gmail.com> (Mehul Jain's message of "Fri, 27 May 2016 11:38:32 +0530")

Mehul Jain <mehul.jain2029@gmail.com> writes:

> On Thu, May 26, 2016 at 10:52 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
>> The only reason why teaching the "--no-show-signature" option to
>> these commands is a good idea is because it would help people who
>> create an alias with "--show-sig" in early part of the command line,
>> e.g.
>>
>>         [alias] fp = format-patch --show-signature
>>
>> by allowing them to countermand with --no-show-signature, i.e.
>>
>>         $ git fp --no-show-signature ...
>> ...
>
> Just out of curiosity, I was thinking that we might be able to teach
> "--no-show-signature" option only to git-show, git-log, git-whatchanged
> and git-reflog.

Yeah, I know it is possible with extra code, but I do not think of a
good reason why it is necessary.

  reply	other threads:[~2016-05-27 17:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-26 13:06 [RFC/PATCH 0/2] Introduce "log.showSignature" config variable Mehul Jain
2016-05-26 13:06 ` [RFC/PATCH 1/2] log: add "log.showsignature" configuration variable Mehul Jain
2016-05-26 13:42   ` Remi Galan Alfonso
2016-05-26 15:04     ` Mehul Jain
2016-05-26 15:43       ` Remi Galan Alfonso
2016-05-26 16:06         ` Mehul Jain
2016-05-27  4:01       ` Pranit Bauva
2016-05-26 16:59   ` Jeff King
2016-05-27  6:04     ` Mehul Jain
2016-05-26 13:06 ` [RFC/PATCH 2/2] log: add "--no-show-signature" command line option Mehul Jain
2016-05-26 16:32   ` Jeff King
2016-05-26 16:42     ` Mehul Jain
2016-05-26 17:01       ` Jeff King
2016-05-26 17:22     ` Junio C Hamano
2016-05-27  6:08       ` Mehul Jain
2016-05-27 17:37         ` Junio C Hamano [this message]
2016-05-27 17:48           ` Jeff King
2016-05-27  2:55 ` [RFC/PATCH 0/2] Introduce "log.showSignature" config variable Austin English

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4m9js8qb.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=austinenglish@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=mehul.jain2029@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.