From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Git Mailing List <git@vger.kernel.org>,
Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: [PATCH 0/4] Fix file locking with retry and timeout on Windows
Date: Fri, 05 Jun 2015 12:57:13 -0700 [thread overview]
Message-ID: <xmqq4mmmrkrq.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <cover.1433532967.git.j6t@kdbg.org> (Johannes Sixt's message of "Fri, 5 Jun 2015 21:45:03 +0200")
Johannes Sixt <j6t@kdbg.org> writes:
> The remaining 3 patches replace the select() invocation that waits
> for a short time period by the version with poll() that we already
> use in help.c. This is necessary because a select() call where all
> three sets of file descriptors are empty is not supported on Windows.
Thanks.
The use of both select() and poll() in our code has been bugging me
for a long time (but wasn't irritating enough to make me do anything
about it).
>
> Johannes Sixt (4):
> lockfile: replace random() by rand()
> help.c: wrap wait-only poll() invocation in sleep_millisec()
> lockfile: convert retry timeout computations to millisecond
> lockfile: wait using sleep_millisec() instead of select()
>
> cache.h | 1 +
> help.c | 2 +-
> lockfile.c | 31 +++++++++----------------------
> wrapper.c | 5 +++++
> 4 files changed, 16 insertions(+), 23 deletions(-)
next prev parent reply other threads:[~2015-06-05 19:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-30 6:23 [PATCH mh/lockfile-retry] lockfile: replace random() by rand() Johannes Sixt
2015-05-30 17:12 ` Junio C Hamano
2015-06-04 8:40 ` Johannes Sixt
2015-06-04 11:42 ` Michael Haggerty
2015-06-04 15:57 ` Junio C Hamano
2015-06-05 19:45 ` [PATCH 0/4] Fix file locking with retry and timeout on Windows Johannes Sixt
2015-06-05 19:45 ` [PATCH 1/4] lockfile: replace random() by rand() Johannes Sixt
2015-06-05 19:45 ` [PATCH 2/4] help.c: wrap wait-only poll() invocation in sleep_millisec() Johannes Sixt
2015-06-05 19:45 ` [PATCH 3/4] lockfile: convert retry timeout computations to millisecond Johannes Sixt
2015-06-05 19:45 ` [PATCH 4/4] lockfile: wait using sleep_millisec() instead of select() Johannes Sixt
2015-06-05 19:57 ` Junio C Hamano [this message]
2015-06-05 20:14 ` [PATCH 0/4] Fix file locking with retry and timeout on Windows Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4mmmrkrq.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.