From: Junio C Hamano <gitster@pobox.com>
To: Shawn Landden <shawn@churchofgit.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Git List <git@vger.kernel.org>,
Shawn Landden <shawnlandden@gmail.com>
Subject: Re: [PATCH] systemd socket activation support
Date: Thu, 02 Apr 2015 08:47:04 -0700 [thread overview]
Message-ID: <xmqq4moyleh3.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cQVLGAYKNJf2dZGpnZbU-GBzeVKpQG48cpFtX8uYZ_LPQ@mail.gmail.com> (Eric Sunshine's message of "Thu, 2 Apr 2015 01:59:14 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> On Wed, Apr 1, 2015 at 9:23 PM, Shawn Landden <shawn@churchofgit.com> wrote:
>> From: Shawn Landden <shawnlandden@gmail.com>
>>
>> [PATCH] systemd socket activation support
>
> This patch feels like an RFC rather than a properly fleshed-out
> submission. If so, indicate such in the subject. Also, mention the
> area you're touching, followed by a colon, followed by the summary of
> the change:
>
> [PATCH/RFC] daemon: add systemd support
> ...
Everything Eric said ;-)
Another thing is that this must be a build-time conditional. Not
all platforms can use systemd in the first place, and some people
may choose not to use it even if the platform is capable of.
I was somewhat surprised that sd-daemon.c needed to be built on our
side, not used from systemd support library, as what it did looked
very common and not specific to our needs. I would have expected to
see inclusion of "sd-daemon.h" with -lsystemd-daemon or something on
the command line.
next prev parent reply other threads:[~2015-04-02 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 1:23 [PATCH] systemd socket activation support Shawn Landden
2015-04-02 5:59 ` Eric Sunshine
2015-04-02 15:47 ` Junio C Hamano [this message]
2015-04-02 16:18 ` Shawn Landden
-- strict thread matches above, loose matches on Subject: below --
2015-04-02 6:09 Shawn Landden
2015-04-08 14:26 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4moyleh3.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=shawn@churchofgit.com \
--cc=shawnlandden@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.